Handling php errors after ajax call

Question

I'm having some trouble getting the errors from a php script called with Ajax. I've got an ajax which is directing to a suppression script.
Here's my Js :

$('.js-delete-link').click(function (e) {
    e.preventDefault();
    let id = $(this).closest('tr').find('.id').text();
    if (confirm('Voulez-vous vraiment supprimer le message ?')) {
        let href = $(e.currentTarget).attr('href');
        $.ajax({
            url:href,
            type:'post',
            success:function(data){
                let msgJson = JSON.parse(data);                  
                bootstrapNotify(msgJson.msg,msgJson.type);
            },
        })
    }
});

and here's my php script where i'm actually deleting the items.

if ($_SERVER['REQUEST_METHOD'] === 'POST') {

if (isset($_GET['id'])) {

    $id = FILTER_INPUT(INPUT_GET, 'id', FILTER_VALIDATE_INT);
    if ($id === false) {
        $arr = array("msg" => "Id incorrect ou non spécifié", "type" => 'danger');
    } else {
        if ($messageModelDb->delete($id)) {
            $arr = array("msg" => "Le ou les messages ont été supprimés", "type" => 'success');
        } else {
            $arr = array("msg" => "Le message n'existe pas !", "type" => 'danger');
        }
    }
}

echo json_encode($arr);

} else {
    $_SESSION['error'] = "Vous n'êtes pas autorisé.";
    redirect('liste-messages');
}

In my php i try to catch any error which could occur during the query and if it happens i pass a message according to the error.
However, no matter what i always get a success message even if the id does not exist.
Sorry if this may seem totally obvious but i'm new to all this and i'm kind of stuck here!
Thank you for your help !

server side redirect will not redirect the browser page while doing an ajax call — charlietfl
– charlietfl, Commented Oct 21, 2017 at 12:35

jeroen e · Accepted Answer · 2017-10-22 14:16:49Z

1

if isset($_GET['id']) is false, nothing will happen because you should put the else statement like this:

<?php

if ($_SERVER['REQUEST_METHOD'] === 'POST') {
    if (isset($_GET['id'])) {

        $id = FILTER_INPUT(INPUT_GET, 'id', FILTER_VALIDATE_INT);
        if (!$id) {
            $arr = array("msg" => "Id incorrect ou non spécifié", "type" => 'danger');
        } else {
            if ($messageModelDb->delete($id)) {
                $arr = array("msg" => "Le ou les messages ont été supprimés", "type" => 'success');
            } else {
                $arr = array("msg" => "Le message n'existe pas !", "type" => 'danger');
            }
        }
    } else {
        $arr = array("msg" => "ID is not set", "type" => 'danger');
    }
} else {
    $arr = array("msg" => "Invalid request method", "type" => 'danger');
}

echo json_encode($arr);

Then in the Javascript file, you can add an error callback:

success: function(){  
    ... 
},
error: function(XMLHttpRequest, textStatus, errorThrown) { 
    alert("Status: " + textStatus + " - Error: " + errorThrown); 
}

edited Oct 22, 2017 at 14:16

answered Oct 21, 2017 at 12:35

jeroen e

1446 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Simondebn Over a year ago

Ok that did it but then i've got to handle the errors in the ajax callback right ? not in the php script ?

Simondebn Over a year ago

Ok thank you so much ! One more thing though, when i try and put a wrong id in my link i still get a answer as if the item existed and i don't really understand why ?

Simondebn Over a year ago

This is also true if the id is empty

jeroen e Over a year ago

I editted my anwser to complete the PHP code. I tested it and it works, Assuming there is nothing wrong with $messageModelDb->delete($id).

AlexandrX · Accepted Answer · 2017-10-21 12:40:14Z

0

AFAIK, the FILTER_INPUT could return NULL too, so $id === false will be false in this case. Try to use if(!$id) instead, if you sure that your $id could not be 0

answered Oct 21, 2017 at 12:40

AlexandrX

8489 silver badges20 bronze badges

3 Comments

jeroen e Over a year ago

If $id = NULL, its still false: php.net/manual/en/types.comparisons.php. I think it's best to do if(!isset($id) && $id !== "") here

AlexandrX Over a year ago

@jeroene wait... if(!$id) will be true in both cases, when $id is null and when $id is false, so we can use it so to test $id, no?

jeroen e Over a year ago

@AlexandrX Ah sorry, you're right.. Only note that if $id is 0 or "0", it will be false. Since I guess we can assume that $id will never be 0, !$id should be good.

Collectives™ on Stack Overflow

Handling php errors after ajax call

2 Answers 2

4 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related