Python accessing parent variable inside nested function

Question

def download(self):
    ftp = self.connect()
    try:
        size = ftp.size(filename=self.filename)
        print "Total size of {filename} is {size}".format(filename=self.filename, size=size)
        written_till_now = 0
        def handle(bytes):
            f.write(bytes)
            print "written bytes: {}".format(bytes)

        with open(self.filename, 'wb') as f:
            ftp.retrbinary('RETR {}'.format(self.filename), handle)
    except (socket.error, error_perm) as e:
        raise DownloaderException("Error in downloading file {filename}: {message}".format(filename=self.filename, message=str(e)))
    except EOFError as e:
        print "file {filename} downloaded successfully".format(filename=self.filename)

I want to keep track of the amount of data i've currently downloaded and later do some additional stuff also for every stream of data i download.

I created a handle function inside the download function.

Python ftblip.retrbinary provides the data to the given callback. In my case handle but somehow it is not executing.

Also I doubt i am not understanding the scope of variables when it comes to nested functions. In my understanding I can use variable defined in parent scope in the child scope as long as i am not modifying them.But in this case f is a object and i am not modifying it rather calling its method write. Please correct me if i am missing something.

I am putting it insie because later i will build a progressbar which will take. so the variable written_till_now i will access and increment — Raheel
– Raheel, Commented Oct 30, 2017 at 12:45
I think its because i am not even getting a single byte. It throws exception o connection refused after a while. — Raheel
– Raheel, Commented Oct 30, 2017 at 12:45
I would put it inside the with block because you are using f variable which is defined there. — Aleksandr Borisov
– Aleksandr Borisov, Commented Oct 30, 2017 at 12:48
are you able to get a successful ftp connection ? try to print something before and after ftp = self.connect() , if not this might help — Ankush Rathi
– Ankush Rathi, Commented Oct 30, 2017 at 12:52

Håken Lid · Accepted Answer · 2017-10-30 12:55:43Z

1

The handle function doesn't have access to the scoped f variable. Instead you can pass the open file directly to handle.

def handle(fp, bytes):
    fp.write(bytes)
    print "written bytes: {}".format(bytes)

with open(self.filename, 'wb') as f:
    ftp.retrbinary('RETR {}'.format(self.filename), lambda b: handle(f, b))

answered Oct 30, 2017 at 12:55

Håken Lid

23.2k10 gold badges58 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Raheel Over a year ago

lambda b: means that the ftp will use the b variable ?

Håken Lid Over a year ago

It means that the callback function takes a single argument, which we call b.

Collectives™ on Stack Overflow

Python accessing parent variable inside nested function

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related