Display a link in javascript if var is not empty. checking var endefined not working [duplicate]

Question

I need to display a link in sweetalert html only if the var is not empty. Here is the code:

$('.patient-details').click(function(e) {
e.preventDefault();
var $this = $(this)
var name = $this.data('name');
var gender = $this.data('gender');
var age = $this.data('age');
var country = $this.data('country');
var address = $this.data('address');
var report = $this.data('report');
swal({
title: name,
html:
    "Gender: " + gender +"<br>" +
   "Age: " + age +"<br>" +
   "Country: " + country +"<br>" +
   "Address: " + address +"<br>" +
   (report!=undefined?'<a href="' + report + '" target="_blank">View Report</a>':''),
});
});

I need the report link to be displayed only if var report is not empty. Here is the code pen: https://codepen.io/pamela123/pen/GOJZgo

I tried

if(report){
report = $this.data('report');
}

report is "undefined". report!=undefined is not working.

But how not to display the report link inside the html if report is empty ??

I know it is a simple javascript question, but being a newbie i could not get further.

Just put a check if it is blank, then do not include the anchor. — Mayank Pandeyz
– Mayank Pandeyz, Commented Oct 31, 2017 at 12:07
It seems like your variable has the content "undefined" according to your question. This indicates that it is a string. Which will lead the if statement to be true — kevinSpaceyIsKeyserSöze
– kevinSpaceyIsKeyserSöze, Commented Oct 31, 2017 at 12:15
@ kevinSpaceyIsKeyserSöze Which is exactly my question. It is not working as can be seen in the codepen. codepen.io/pamela123/pen/GOJZgo — Pamela
– Pamela, Commented Oct 31, 2017 at 12:21
@Pamela can't see that the report value is undefined. Can you provide a codepen when it is undefined? — kevinSpaceyIsKeyserSöze
– kevinSpaceyIsKeyserSöze, Commented Oct 31, 2017 at 12:25

GreyRoofPigeon · Accepted Answer · 2017-10-31 12:35:51Z

1

Put the data in a separate variable.

Then check if report is not undefined. If not, add it to the variable.

$('.patient-details').click(function(e) {
  e.preventDefault();
  var $this = $(this)
  var name = $this.data('name');
  var gender = $this.data('gender');
  var age = $this.data('age');
  var country = $this.data('country');
  var address = $this.data('address');
  var report = $this.data('report');

  var htmlData = "Gender: " + gender + "<br>" +
      "Age: " + age + "<br>" +
      "Country: " + country + "<br>" +
      "Address: " + address + "<br>";
  if( report !== undefined && report != "" ) {
    htmlData +=  '<a href="' + report + '" target="_blank">View Report</a>'
  }
  swal({
    title: name,
    html: htmlData
  });
});

edited Oct 31, 2017 at 12:35

answered Oct 31, 2017 at 12:24

GreyRoofPigeon

18.1k5 gold badges39 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Pamela Over a year ago

Sorry..Not working.

Pamela Over a year ago

After changing if( report)..it will work. But not if report !== undefined. which was my question. Wonder why report !== undefined is not working ??

GreyRoofPigeon Over a year ago

Works for me: codepen.io/anon/pen/XzbpBK

GreyRoofPigeon Over a year ago

I have added && report. With that addition it works when the data-report attribute is empty and if the attribute isn't set at all (codepen.io/anon/pen/VrLPVQ)

GreyRoofPigeon Over a year ago

Then try the code again, I've changed it in my answer

|

Nitishkumar Singh · Accepted Answer · 2017-10-31 12:24:38Z

1

You Can Update your Code as below

var htmlTemplate="Gender: " + gender +"<br>" +"Age: " + age +"<br>" + "Country: " + country +"<br>" + "Address: " + address +"<br>" ;
if(report){
   htmlTemplate+= '<a href="' + report + '" target="_blank">View Report</a>';
}
swal({
title: name,
html: htmlTemplate,
});

edited Oct 31, 2017 at 12:24

answered Oct 31, 2017 at 12:12

Nitishkumar Singh

1,8371 gold badge18 silver badges34 bronze badges

4 Comments

Pamela Over a year ago

Why is report !== undefined not working??? Your solution works. But my question was why undefined is not working ??

Nitishkumar Singh Over a year ago

Since you are passing data-report="", that is why it's not working for undefined

Pamela Over a year ago

if( report !== undefined && report != "" ) will work. As i am getting the value from a DB. In some cases it may be empty. Please See the accepted answer.

Nitishkumar Singh Over a year ago

If You remove report !="", that code will also not work. I would recommend you to read developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/…, you will get more clarity on conditions

Sandeep · Accepted Answer · 2017-10-31 12:55:06Z

0

$('.patient-details').click(function(e) {
e.preventDefault();
var $this = $(this)
var name = $this.data('name');
var gender = $this.data('gender');
var age = $this.data('age');
var country = $this.data('country');
var address = $this.data('address');
var report = $this.data('report');
swal({
title: name,
html:
    "Gender: " + gender +"<br>" +
   "Age: " + age +"<br>" +
   "Country: " + country +"<br>" +
   "Address: " + address +"<br>" +(typeof report !== "undefined" && report != ""?'<a href="' + report + '" target="_blank">View Report</a>':'')
    ,
});
});

edited Oct 31, 2017 at 12:55

answered Oct 31, 2017 at 12:06

Sandeep

4211 gold badge4 silver badges13 bronze badges

4 Comments

Pamela Over a year ago

report!=null? is not working.

Sandeep Over a year ago

use typeof report != "undefined" instead of that

Pamela Over a year ago

Sorry..That is not working either.

Sandeep Over a year ago

Check the above code that will work (typeof report !== "undefined"?'<a href="' + report + '" target="_blank">View Report</a>':'')

Collectives™ on Stack Overflow

Display a link in javascript if var is not empty. checking var endefined not working [duplicate]

3 Answers 3

10 Comments

4 Comments

4 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

10 Comments

4 Comments

4 Comments

Linked

Related