Error when trying to work with nested objects with constructor

Question

I'm getting the following error when trying to create a nested object using a constructor:

Uncaught TypeError: Cannot read property 'data' of undefined

Here's my code:

function Car(name){
    this.name.data.CarName = name;
    this.show = function(){document.getElementById("fill").innerHTML = toyota.name.data.CarName;};
}
var toyota;
function functionadd(){
    toyota = new Car("Toyota");
    toyota.show();
}

I have looked this up everywhere and can't seem to find an answer and am wondering if I'm making some stupid mistake. Any help is fantastic, thanks :)

Faly · Accepted Answer · 2017-11-03 06:46:03Z

1

It's because object name is undefined and there is also no property data on it, so you have to initialize this.name and this.name.data before adding CarName:

function Car(name){
    this.name = {};
    this.name.data = {};
    this.name.data.CarName = name;
    this.show = function(){document.getElementById("fill").innerHTML = toyota.name.data.CarName;};
}

It's shorter with object litteral:

function Car(name){
    this.name = { data: { CarName: name } };
    this.show = function(){document.getElementById("fill").innerHTML = toyota.name.data.CarName;};
}

edited Nov 3, 2017 at 6:46

answered Nov 3, 2017 at 6:39

Faly

13.4k2 gold badges21 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Error when trying to work with nested objects with constructor

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related