convert array into proper JSON format for android using PHP

Question

I am using Codeigniter to fetch rows. Please go through the below code.

//Model

public function selectData() {
    $query = $this->db->query('SELECT * FROM tbl_favourites WHERE favourites_status = 1');
    $count = $query->num_rows();

    if($count > 0)
        return $result = $query->result_array();
    else
        return 0;
}

//Controller

$all_favourites = $this->select->selectData();

if(!empty($all_favourites)) {
    foreach($all_favourites as $favourites)
        echo json_encode($favourites);
}

From the above code, the output is

{"favourite_online_id":"3","favourite_online_url":"ddd","favourite_online_status":"0"}
{"favourite_online_id":"2","favourite_online_url":"http:\/\/www.google.com","favourite_online_status":"0"}

But I want the output to be formatted properly to satisfy the android JSON.

The required output is,

[
  {
    "favourite_online_id": "3",
    "favourite_online_url": "ddd",
    "favourite_online_status": "0"
  },
  {
    "favourite_online_id": "2",
    "favourite_online_url": "http://www.google.com",
    "favourite_online_status": "0"
  }
]

instead of encoding in foreach encode the main array. json_encode($all_favourites) — urfusion
– urfusion, Commented Nov 14, 2017 at 8:21

Shankar · Accepted Answer · 2017-11-14 08:21:53Z

1

instead of using

if(!empty($all_favourites)) {
    foreach($all_favourites as $favourites)
        echo json_encode($favourites);
}

use directly

if(!empty($all_favourites)) {

        echo json_encode($all_favourites );
}

answered Nov 14, 2017 at 8:21

Shankar

3,0863 gold badges28 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Yusril Herlian Syah · Accepted Answer · 2017-11-14 08:25:53Z

1

I think you can modify your function

public function selectData() {
    $query = $this->db->query('SELECT * FROM tbl_favourites WHERE favourites_status = 1');
    $count = $query->num_rows();

    if($count > 0)
        return $result = $query->result_array();
    else
        return array();
}

//Controller

$all_favourites = $this->select->selectData();

// if(!empty($all_favourites)) {
//    foreach($all_favourites as $favourites)
//        echo json_encode($favourites);
// }
echo json_encode($all_favourites);

answered Nov 14, 2017 at 8:25

Yusril Herlian Syah

4971 gold badge6 silver badges12 bronze badges

Comments

Ujjaval · Accepted Answer · 2017-11-14 08:59:10Z

1

You can do in 2 way

1st way

if(!empty($all_favourites)) {
  echo json_encode($all_favourites);
}

2nd way

if you want to add something in that object then

$favouriteArray=[];
if(!empty($all_favourites)) {
    foreach($all_favourites as $favourites){
      array_push($favouriteArray, $favourites);
    }
}
echo json_encode($favouriteArray);

edited Nov 14, 2017 at 8:59

answered Nov 14, 2017 at 8:23

Ujjaval

4475 silver badges10 bronze badges

Collectives™ on Stack Overflow

convert array into proper JSON format for android using PHP

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related