JavaScript won't output value in function

Question

Hi I am very new to Javascript. In the code below, when I test I don't see any output. Can anybody tell me what is wrong?

    <script>
        function myFunction()
        {
            var x="";
            var score=document.myscore.score.value;

            if (score>30)
            {
                x="Expert";
            }
            else
            }
                x="Novice";
            }
            document.write(x);
        }
    </script>
</head>
<body>
    <form name="myscore">
        Score: <id="score"> <input type="number" name= "score">
        <input type="submit" onClick="myFunction()" value="submit">

    </form>


</body>

The bracket after else is into the wrong direction. Ask your console! She will tell you... — Jonas Wilms
– Jonas Wilms, Commented Nov 19, 2017 at 10:40
I'm voting to close this question as off-topic because it's a small typo. — Milan Chheda
– Milan Chheda, Commented Nov 19, 2017 at 11:00
Thanks, I am not using a console as I am simulating the situation of my students in a lesson. (I've started teaching computer science again after a long hiatus teaching other subjects.). Obviously my skills in spotting syntax errors need work. — Adrian Peace
– Adrian Peace, Commented Nov 19, 2017 at 18:18

Nacev · Accepted Answer · 2017-11-19 10:45:28Z

1

<script>
function myFunction()
{
var x="";
var        score=document.myscore.score.value;

if (score>30)
        {
            x="Expert";
        }
        else
        {
            x="Novice";
        }
        document.write(x);
    }
</script>
</head>
<body>
<form name="myscore">
Score: <id="score"> <input type="number" name= "score">
<input type="submit" onClick="myFunction()" value="submit">

</form>


</body>

This should work! The problem was the orientatiom of { after the else.

answered Nov 19, 2017 at 10:45

Nacev

1548 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vergil Penkov · Accepted Answer · 2017-11-19 10:47:20Z

1

A few things:

<id="score"> <input type="number" name= "score"> is probably not what you mean. Maybe you mean <input type="number" name="score" id="score">.
document.write is a no-no, please don't ever use it. It allows you to modify the document "here and now", i.e. while it's loading. Use document.body.innerHTML += x, for example.
var score = document.getElementByID('score').value
The bracket after the else clause

answered Nov 19, 2017 at 10:47

Vergil Penkov

3552 silver badges11 bronze badges

Comments

Naresh Singh · Accepted Answer · 2017-11-19 10:54:49Z

0

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>Document</title>
</head>enter code here
 <script>
        function myFunction()
        {
            var x="";
            var score=document.myscore.score.value;

            if (score>30)
            {
                x="Expert";
            }
            else
             {
                x="Novice";
            }
            document.write(x);
        }
    </script>
</head>
<body>
    <form name="myscore">
        Score: <id="score"> <input type="number" name= "score">
        <input type="submit" onClick="myFunction()" value="submit">

    </form>


</body>
</html>

answered Nov 19, 2017 at 10:54

Naresh Singh

195 bronze badges

1 Comment

mx0 Over a year ago

While this code may answer the question, providing additional context regarding how and/or why it solves the problem would improve the answer's long-term value.

kiranvj · Accepted Answer · 2017-11-19 11:39:20Z

0

Change input type from submit to button else you wont be able to see the output, because the form will submit and reload the page.
Fix the syntax errors ~~<id="score">~~ Change } to { under else condition
Change document.write to alert or console.log

answered Nov 19, 2017 at 11:39

kiranvj

34.2k8 gold badges75 silver badges81 bronze badges

Comments

Darius Buhai · Accepted Answer · 2017-11-19 12:34:39Z

0

Try this:

  <script>
    function myFunction()
    {
        var x;
        var score=document.getElementById("in_score").value;

        if(score>30)
          x="Expert";
        else
          x="Novice";
        document.getElementById("score").value = x;
    }
  </script>
  <body>
    <form name="myscore">
     Score: <input id="score" type="number" name= "score">
     <input type="submit" id="in_score" onClick="myFunction()" value="submit">

    </form>


   </body>
   </html>

So the main error in your code was the reverse bracket from the else statement. Also, to get/change values from an input, you need to use getElementById ( to select the element ), and .value statement, to change/get it.

edited Nov 19, 2017 at 12:34

answered Nov 19, 2017 at 10:46

Darius Buhai

612 silver badges12 bronze badges

2 Comments

Useless Code Over a year ago

Your code looks good, but you should add some explanation of what is going on in it to help the OP understand what you are doing here. How do I write a good answer.

Darius Buhai Over a year ago

Something like this?

Collectives™ on Stack Overflow

JavaScript won't output value in function

5 Answers 5

Comments

Comments

1 Comment

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related