JSON values in php foreach gives incorrect json encoded output

Question

I have ajax url php code as follows:

<?php
if (isset($_POST["icdmaincode"]) && !empty($_POST["icdmaincode"])) 
{
    $icd_main_code = strip_tags(trim($_POST["icdmaincode"]));
}
$stmt5 = $conn->prepare("SELECT icd_sub_code,icd_sub_code_description 
                        FROM icd_sub_code 
                        WHERE icd_main_code = :icdmaincode");
$stmt5->bindValue(':icdmaincode', $icd_main_code);
$stmt5->execute();
$row = $stmt5->fetchAll(PDO::FETCH_ASSOC);
foreach($row as $key => $value)
{
    echo json_encode(array($key => $value));
}
$conn = null;
?>

and it is giving output as follows which is not valid json.

[{"icd_sub_code":"icdcat1-1","icd_sub_code_description":"(A00-A09) Intestinal infectious diseases"}]
{"1":{"icd_sub_code":"icdcat1-2","icd_sub_code_description":"(A15-A19) Tuberculosis"}}
{"2":{"icd_sub_code":"icdcat1-3","icd_sub_code_description":"(A20-A28) Certain zoonotic bacterial diseases"}}

and hence the following ajax success code is not working:

success: function(data){
    var subcode = data.icd_sub_code;
    var subcodedescription = data.icd_sub_code_description;
    subcode = JSON.parse(subcode);  
    alert(subcode); 
    .....

What am i doing wrong ?? How can i resolve it ??

You are returning an JSON array of objects. So your javascript needs to process data as an array. Assuming you have taken @AbraCadaver advice on the PHP Code — RiggsFolly
– RiggsFolly, Commented Nov 28, 2017 at 18:14

AbraCadaver · Accepted Answer · 2017-11-28 18:21:25Z

2

Normally you would build an array, encode and then display:

foreach($row as $key => $value)
{
    $data[] = array($key => $value);
}
echo json_encode($data);

But you actually have it all already in that type of array, so no need to loop:

echo json_encode($row);

Also, just FYI empty checks isset so just:

if (!empty($_POST["icdmaincode"]))

edited Nov 28, 2017 at 18:21

answered Nov 28, 2017 at 18:11

AbraCadaver

79.2k7 gold badges75 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

RiggsFolly Over a year ago

You might want to also add some array processing into the javascript code

Pamela Over a year ago

@AbraCadaver oops..I overlooked the fact that $row was an array. Newbie programmer oversight. Thank you very much :)

Collectives™ on Stack Overflow

JSON values in php foreach gives incorrect json encoded output

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related