.updateOne on MongoDB not working in Node.js

Question

I have the following code:

connection((db) => {
            db.collection('orders')
                .updateOne(
                    { "_id": req.body._id}, // Filter
                    {"name": req.body.name} // Update
                )
                .then((obj) => {
                    console.log('Updated - ' + obj);
                    res.redirect('orders')
                })
                .catch((err) => {
                    console.log('Error: ' + err);
                })
        })

I want to change the name in the order but it doesn't update it. The result in the console is

Updated - {"n":0,"nModified":0,"ok":1}

I tried to read the documentation but it's horrific

EDIT: {$set: {"name": req.body.name}}, didn't work as well

EDIT 2: The passed ID matches the _id in the database. Could it be a problem that I'm querying for plain text ID while in the database it is referred to as "ObjectId('5a42ja...')"

The documentation is fine just always look for the "examples" section: try { db.restaurant.updateOne( { "name" : "Central Perk Cafe" }, { $set: { "violations" : 3 } } ); } catch (e) { print(e); } — ThatBrianDude
– ThatBrianDude, Commented Dec 5, 2017 at 15:02
Hmm I'm talking about the documentation related to node.js. I can't write queries like that in there (or can I?) — Simeon Nakov
– Simeon Nakov, Commented Dec 5, 2017 at 15:05
can u please share 2 3 mongo documents? Also what will be value of req.body._id? — Datta
– Datta, Commented Dec 5, 2017 at 15:10

Sparw · Accepted Answer · 2017-12-05 15:15:15Z

72

Maybe you should use "$set" in your update query like this :

{$set: {"name": req.body.name}}, // Update

2 Comments

Sparw Over a year ago

Maybe it's because there is no match with your filter ? Can you try to find a document with { "_id": req.body._id} ?

Simeon Nakov Over a year ago

Hmm the ID passed in req.body._id is the same as the ID in the database, however it is passed as a string, while in the database, it is of type ObjectId(). Could it be that it's not filtering it.because of that?

Dan Porat · Accepted Answer · 2017-12-05 15:14:11Z

11

Use {$set: {"name": req.body.name}} (as Sparw mentioned) to update the the properties you want in the document. Also, if the id that you pass as a parameter does not exists in the collection (and you want to create one with the same id) you can pass as a third parameter {upsert: true} to create one.

In your example:

connection((db) => {
          db.collection('orders')
               .updateOne(
                  { "_id": req.body._id}, // Filter
                  {$set: {"name": req.body.name}}, // Update
                  {upsert: true} // add document with req.body._id if not exists 

             )
            .then((obj) => {
               console.log('Updated - ' + obj);
              res.redirect('orders')
         })
        .catch((err) => {
           console.log('Error: ' + err);
      }) })

answered Dec 5, 2017 at 15:14

Dan Porat

4462 silver badges6 bronze badges

1 Comment

Yuriy Tigiev Over a year ago

I can't understand the logic, but for find and updateOne you should use different syntacsis for search by id. Samples: - db.admins.find({ id: req.params.id, isDeleted: false }) and db.admins.updateOne( { _id: new ObjectID(req.params.id), isDeleted: false}. Simple question - WHY?

Dirk · Accepted Answer · 2021-09-15 12:19:42Z

8

The correct syntax is:

monDb.collection.updateOne(
    {"_id": ObjectId(req.params.id)}, 
    { $set: updateDoc }, 
    function(err, doc) {
      ...
    }
);

UPDATE: Not ObjectID but ObjectId.

edited Sep 15, 2021 at 12:19

Dirk

2,42527 silver badges37 bronze badges

answered Dec 22, 2019 at 21:55

Victor Vargas

811 silver badge3 bronze badges

1 Comment

unflores Over a year ago

Hey @victor thanks for the answer but would you go more into detail please. It would be useful to know where OP is actually making a mistake in their syntax.

Yuvaraj Anbarasan · Accepted Answer · 2020-11-13 08:13:15Z

5

This might happen if the collection schema is missing the field that is to be updated. If the schema is not strict (i.e, isStrict: false), check the update operator. In some cases, the new update value can be same as existing value. In this case, mongoose returns

{ n: 1, nModified: 0, ok: 1 }

answered Nov 13, 2020 at 8:13

Yuvaraj Anbarasan

6579 silver badges8 bronze badges

Comments

MajidJafari · Accepted Answer · 2019-03-07 17:32:58Z

4

Tough @Spraw's answer is right for some cases, but sometimes it doesn't work. I think the convenient answer is updateOne({_id: new ObjectID(req.body._id)}, {$set: {"name": req.body.name}}, callback).

the _id in mongodb is a BSON object and should be instantiated.

answered Mar 7, 2019 at 17:32

MajidJafari

1,13013 silver badges17 bronze badges

1 Comment

tmsss Over a year ago

That seemed to be the case for me, it only worked when I added the callback function.

maiko · Accepted Answer · 2019-09-27 16:54:56Z

1

For me, I have to delete the "_id"/id field before passing the object in the update.

Or it will say that the field is invalid.

Obviously, updated the key while you're using it as a reference isn't the best thing to do.

answered Sep 27, 2019 at 16:54

maiko

4051 gold badge4 silver badges15 bronze badges

Comments

David Cardoso · Accepted Answer · 2020-09-10 15:17:48Z

-1

I had this trouble too, I create a constant with _id from req.body

const {_id} = req.body  //pass ID user
await User.updateOne({_id},{$set:data}, (err)=>{
            if(err) return res.status(200).json({
                error: true,
                code: 115,
                message: "Erro to update user!"
            })
        })

answered Sep 10, 2020 at 15:17

David Cardoso

11 bronze badge

1 Comment

Binni kumari Over a year ago

You can assign _id directly to updateone method. Like - User.updateOne({req.body._id},{$set:data}

Luis Moreno · Accepted Answer · 2021-04-03 20:18:44Z

-1

En NEXT.js

My project is on React and Next.js. I had this issue. My silly solution was Restart with (next dev) xD

I added two fields to my Schema model and I tried to update that new fields, but did not works until i restart mi project.

I hope to save time for someone. :)

answered Apr 3, 2021 at 20:18

Luis Moreno

7236 silver badges6 bronze badges

Comments

Mahesh · Accepted Answer · 2022-09-07 07:55:57Z

-1

after spending couple of hours on it I found out that for update I had to convert the id value to Integer, this was however not required where only find was being used

dbCollection.updateOne({ _id: parseInt(reqBody.id) }

answered Sep 7, 2022 at 7:55

Mahesh

411 silver badge7 bronze badges

Collectives™ on Stack Overflow

.updateOne on MongoDB not working in Node.js

9 Answers 9

2 Comments

1 Comment

1 Comment

Comments

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

9 Answers 9

2 Comments

1 Comment

1 Comment

Comments

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related