Spring Controller double validation for @ModelAttribute object

Question

I have implemented controller with method:

public Page<EventDto> search(@ModelAttribute @Valid EventsCriteria criteria){...}

It works. EventsCriteria did not have special separate validator for itself, because it has inner annotation checkers like @NotNull @NotEmpty. Right now situation is changed and it's not enough to have only this validators. so I've added and registered correspond service to verify some sates.

I want service to verify additional composite cases and single validation like before. But my single inner annotation checkers like @NotNull @NotEmpty do not work any more.

Am I configured something incorrectly or it can't work in in same time(specified service and inner checkers)?

My validator example (as it was asked in comments)

There are nothing special, if you know spring, so I missed this part like unimportant to concentrate your attention on my question.

@Component
public class EventsCriteriaValidator implements Validator {

    public static final String INVALID_RAGE_PARAMETERS_SPECIFIED = "Invalid rage parameters: please specify " +
            "'from' and 'to' or page 'size";

    @Override
    public boolean supports(Class<?> clazz) {
        return clazz.isAssignableFrom(EventsCriteria.class);
    }

    @Override
    public void validate(Object target, Errors errors) {
        EventsCriteria toValidate = (EventsCriteria) target;
        validateComplexRestriction(toValidate, errors);
    }

    private void validateComplexRestriction(EventsCriteria toValidate, Errors errors) {
        if (toValidate.isRangeEmpty() && toValidate.getSize() == 0) {
            errors.rejectValue(SIZE_FIELD, null, INVALID_RAGE_PARAMETERS_SPECIFIED);
        }
    }

}

BindingResult bindingResult add this in your controller method — Kalaiselvan
– Kalaiselvan, Commented Dec 6, 2017 at 12:55
if(bindingResult.hasErrors()){return "errorr"} check the condition here and return as you want as error message or page — Kalaiselvan
– Kalaiselvan, Commented Dec 6, 2017 at 12:56
@javaguy I'm not sure your request related on solution, but i've just added it any way :) — Serhii
– Serhii, Commented Dec 6, 2017 at 14:56

e2rabi · Accepted Answer · 2017-12-06 17:00:54Z

1

Let assume that your EventsCriteria contains two fields so inside your validate method you can validate those field using : ValidationUtils (org.springframework.validation.ValidationUtils)

 @Override
    public void validate(Object target, Errors errors) {
        EventsCriteria eventsCriteria= (EventsCriteria) target;
        ValidationUtils.rejectIfEmpty(errors, "field1", "eventsCriteria.field1.empty");
        ValidationUtils.rejectIfEmpty(errors, "field2", "eventsCriteria.field2.empty");
    }

and in your messages.properties

eventsCriteria.field1.empty = Enter a valid value for field 1.
eventsCriteria.field2.empty = Enter a valid value for field 2.

and in your configuration class add this bean:

 @Bean
   public MessageSource messageSource() {
      ResourceBundleMessageSource source = new ResourceBundleMessageSource();
      source.setBasename("messages");
      return source;
   }

answered Dec 6, 2017 at 17:00

e2rabi

4,86812 gold badges46 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Serhii Over a year ago

Yea, that works, but it's workaround. I do not want implement behavior if same can be used by default, because of bad practice. but thanks for your attention.

vl4d1m1r4 · Accepted Answer · 2017-12-06 16:55:57Z

0

Just make your Validator extend LocalValidatorFactoryBean and then call super.validate(target, errors) in your validate method like this:

@Override
public void validate(Object target, Errors errors) {
   super.validate(target, errors);

   EventsCriteria toValidate = (EventsCriteria) target;
   validateComplexRestriction(toValidate, errors);
}

answered Dec 6, 2017 at 16:55

vl4d1m1r4

1,79112 silver badges24 bronze badges

1 Comment

vl4d1m1r4 Over a year ago

LocalValidatorFactoryBean handles annotation validation for you, wasn’t that what you need?

gkatiforis · Accepted Answer · 2017-12-06 16:57:35Z

0

Edited:

If you want both custom and default validation you can use addValidators in initBinder to add your custom validations. This way default validations will not be deleted.

@Controller
public class MyController
{
    @Autowired
    private EventsCriteriaValidator validator;

    @InitBinder
    protected void initBinder(final WebDataBinder binder)
    {
         binder.addValidators(validator);
    }

  public Page<EventDto> search(@ModelAttribute @Valid EventsCriteria   criteria, BindingResult result){

     if (result.hasErrors()) {
        // validation failed

     } else {
        //validation passed   
     }
  }

}

edited Dec 6, 2017 at 16:57

answered Dec 6, 2017 at 13:31

gkatiforis

1,6521 gold badge10 silver badges19 bronze badges

1 Comment

Serhii Over a year ago

I need both validations buy default. I expected they'll used both because of @Valid marker.

Collectives™ on Stack Overflow

Spring Controller double validation for @ModelAttribute object

My validator example (as it was asked in comments)

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

My validator example (as it was asked in comments)

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related