How to add URL query parameters to HTTP GET request?

Question

I am trying to add a query parameter to a HTTP GET request but somehow methods pointed out on SO (e.g. here) don't work.

I have the following piece of code:

package main

import (
    "fmt"
    "log"
    "net/http"
)

func main() {
    req, err := http.NewRequest("GET", "/callback", nil)
    req.URL.Query().Add("code", "0xdead 0xbeef")
    req.URL.Query().Set("code", "0xdead 0xbeef")
    // this doesn't help
    //req.URL.RawQuery = req.URL.Query().Encode()

    if err != nil {
        log.Fatal(err)
    }

    fmt.Printf("URL      %+v\n", req.URL)
    fmt.Printf("RawQuery %+v\n", req.URL.RawQuery)
    fmt.Printf("Query    %+v\n", req.URL.Query())
}

which prints:

URL      /callback
RawQuery 
Query    map[]

Any suggestions on how to achieve this?

Playground example: https://play.golang.org/p/SYN4yNbCmo

Something wrong with http.NewRequest("GET", "/callback?code=0xdead 0xbeef", nil)? — Adrian
– Adrian, Commented Dec 7, 2017 at 21:00
@Adrian I didn't want to build the query myself - I have a bunch of variables that I need to attach there — Patryk
– Patryk, Commented Dec 7, 2017 at 21:05

maerics · Accepted Answer · 2017-12-07 21:17:36Z

63

Check the docs for req.URL.Query():

Query parses RawQuery and returns the corresponding values.

Since it "parses RawQuery and returns" the values what you get is just a copy of the URL query values, not a "live reference", so modifying that copy does nothing to the original query. In order to modify the original query you must assign to the original RawQuery.

q := req.URL.Query() // Get a copy of the query values.
q.Add("code", "0xdead 0xbeef") // Add a new value to the set.
req.URL.RawQuery = q.Encode() // Encode and assign back to the original query.

// URL      /callback?code=0xdead+0xbeef
// RawQuery code=0xdead+0xbeef
// Query    map[code:[0xdead 0xbeef]]

Note that your original attempt to do so didn't work because it simply parses the query values, encodes them, and assigns them right back to the URL:

req.URL.RawQuery = req.URL.Query().Encode()
// This is basically a noop!

edited Dec 7, 2017 at 21:17

answered Dec 7, 2017 at 21:02

maerics

157k47 gold badges277 silver badges299 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Patryk Over a year ago

Well then I should hit myself in the head with "RTFM" sign. Thanks!

Danny Kopping Over a year ago

This is a very annoying API :(

natiiix Over a year ago

Thanks for the docs quote because I couldn't figure out why the RawQuery overwrite was necessary just by reading StackOverflow answers.

Arman Ordookhani · Accepted Answer · 2022-05-25 14:11:55Z

4

You can directly build the query params using url.Values

func main() {
    req, err := http.NewRequest("GET", "/callback", nil)
    req.URL.RawQuery = url.Values{
        "code": {"0xdead 0xbeef"},
    }.Encode()

    ...
}

Notice the extra braces because each key can have multiple values.

answered May 25, 2022 at 14:11

Arman Ordookhani

6,5951 gold badge33 silver badges44 bronze badges

Collectives™ on Stack Overflow

How to add URL query parameters to HTTP GET request?

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related