JSON Array element comparion with Java Script Array in Angular 2

Question

I am working on Angular 2 with type script and came up with a very peculiar problem. I have a number array named empIds as

empIds = {1,5,6,9,2}

I have (a JSON Array) named empDetails (please note employeeId is string here)as

empDetails [{"employeeId":"1","employeeName":"Jhon"},
            {"employeeId":"2","employeeName":"Ron"},
            {"employeeId":"3","employeeName":"Van"}]

Now i have to find out the only JSON objects who's id match in number array. Here is what i wrote

for(let i=0;i<empDetails.length;i++){
if(empIds.indexOf(empDetails[i].employeeId)==0 ){
//Employee ID is present save that JSON object to some other JSON Array
i should get details for matched id (1 and 2)
}else{
//Did not match
do nothing
}
}

i did put console.log for both if and else. My loop never matches it always goes to else condition? Is there any possible solution?

Your empIds = {1,5,6,9,2} is not valid. It should be empIds = [1,5,6,9,2]. Change your condition from if(empIds.indexOf(empDetails[i].employeeId)==0 ){ to if(empIds.indexOf(empDetails[i].employeeId) >= 0 ){ — Hassan Imam
– Hassan Imam, Commented Dec 13, 2017 at 18:54

Rohit Ramname · Accepted Answer · 2017-12-13 19:49:23Z

1

The code logic is incorrect. Check index if its greater than -1 Should be as below

 let empIds = [1, 5, 6, 9, 2];
    let empDetails = [{ "employeeId": 1, "employeeName": "Jhon" },
    { "employeeId": 2, "employeeName": "Ron" },
    { "employeeId": 3, "employeeName": "Van" }]
    for (let i = 0; i < empDetails.length; i++) {
      if (empIds.indexOf(empDetails[i].employeeId) > -1) {
        console.log("found");
        console.log(empDetails[i])
      }
    }

answered Dec 13, 2017 at 19:49

Rohit Ramname

8342 gold badges9 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

JavaDeveloper Over a year ago

Hi All, i made a mistake as the JSON array contains details as string and not numbers.[{ "employeeId": "1", "employeeName": "Jhon" }, { "employeeId": "2", "employeeName": "Ron" }, { "employeeId": "3", "employeeName": "Van" }]

JavaDeveloper Over a year ago

Realized a bit late.. but thanks for all your support

Ales · Accepted Answer · 2017-12-13 20:42:00Z

0

const newArray = empDetails.filter(item => empIds.includes(item.employeeId));

I think this is an ok way to get a new array with all the objects from empDetails that have the employeeId in empIds.

.includes() => returns true or false if the empIds contains the employeeId

.filter() => returns all the objects that were true on the include call

empIds = [2];

empDetails = [{"employeeId":1,"employeeName":"Jhon"},
            {"employeeId":2,"employeeName":"Ron"},
            {"employeeId":3,"employeeName":"Van"}]

with my code the new array would be this

[{"employeeId":2,"employeeName":"Ron"}]

because only employeeId = 2 is in empIds table

answered Dec 13, 2017 at 20:42

Ales

566 bronze badges

Comments

cyberpirate92 · Accepted Answer · 2017-12-13 21:06:13Z

0

var filtered = empDetails.filter( (e) => empIds.indexOf(parseInt(e.employeeId)) >= 0 );

If you don't care about support for Internet explorer, you can also use includes() (See answer by Hopless)

edited Dec 13, 2017 at 21:06

answered Dec 13, 2017 at 20:42

cyberpirate92

3,1865 gold badges30 silver badges48 bronze badges

Collectives™ on Stack Overflow

JSON Array element comparion with Java Script Array in Angular 2

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related