Can't Display proper result with Binary Reader

Question

i have made two functions using binary streams

first one takes array as an arguement and writes data in file ... code:

      public static void BinaryWrite(List<person> People)
        {
            string path = @"C:\Users\User\Desktop\filestream.txt";

            using (FileStream fs = new FileStream(path, FileMode.OpenOrCreate, FileAccess.Write))
            {
                using (BinaryWriter bw = new BinaryWriter(fs))
                {
                    for(int i=0;i<People.Count;i++)
                    {
                        bw.Write(People[i].name);
                        bw.Write(People[i].surname);
                        bw.Write(People[i].age);
                    }

                }

            }
        }

Second one should read the data:

  public static void BinaryRead()
    {
        string path = @"C:\Users\User\Desktop\filestream.txt";

        using (FileStream fs = new FileStream(path,FileMode.Open,FileAccess.Read))
        {
            using (BinaryReader br = new BinaryReader(fs))
            {
                for (int i = 0; i < br.BaseStream.Length; i++)
                {
                    Console.WriteLine(br.ReadString());
                }

            }
        }
    }

enter code here

but when i run the code i get the following exception

System.IO.EndOfStreamException: 'Unable to read beyond the end of the stream.'

what can be a problem ?

Emre Kabaoglu · Accepted Answer · 2017-12-14 11:39:21Z

1

You should build the loop by considering BaseStream.Position

using (BinaryReader br = new BinaryReader(fs))
{
    while(br.BaseStream.Position < br.BaseStream.Length)
    {
         Console.WriteLine(br.ReadString());
    }
}

edited Dec 14, 2017 at 11:39

answered Dec 14, 2017 at 11:14

Emre Kabaoglu

13.2k4 gold badges27 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

j.sinjaradze Over a year ago

Well Still getting same exception

Karolis Kajenas · Accepted Answer · 2017-12-14 11:32:47Z

1

ReadString() method requires special format in the string, with prefixed of length on the start of each read.

Instead of having a special format you can just read it like so:

using (FileStream fs = new FileStream(path, FileMode.Open, FileAccess.Read))
{
       using (BinaryReader br = new BinaryReader(fs))
       {
            while (br.BaseStream.Position < br.BaseStream.Length)
            {
                 Console.WriteLine((char)br.Read());
            }
        }
}

edited Dec 14, 2017 at 11:32

answered Dec 14, 2017 at 11:15

Karolis Kajenas

1,5431 gold badge15 silver badges24 bronze badges

1 Comment

j.sinjaradze Over a year ago

Same Expception occured

Collectives™ on Stack Overflow

Can't Display proper result with Binary Reader

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related