Setting variables from remote data in Angular JS

Question

I am calling the function Allow() in html code, if returns true, will allow the user to Edit the data.

The functions $scope.GetCurrentStatus(), $scope.GetCurrentStatus() both are synchronous.

But it returns the following error in Allow() method.

Type Error: Cannot read property 'UserType' of undefined

Help me to handle the situation.

//LoadStatus
$scope.GetCurrentStatus = function () {
    var defer = $q.defer();
    $http({
        method: "POST",
        url: "../Documentation/Documentation.aspx/GetStatus",
        data: {}
    })
    .then(function (response) {
       defer.resolve(response.data.d);
        $scope.Status = response.data.d;
    }),
    function (error) { data, status };
}

$scope.GetCurrentStatus();

//Load AccessRole 
$scope.GetAccessRole = function () {
    var defer = $q.defer();
    $http({
        method: "POST",
        url: "../Documentation/Documentation.aspx/GetAccessRole",
        data: {}
    })
   .then(function (response) {
       defer.resolve(response.data.d);
       $scope.Access = response.data.d;
   }),
   function (error) { data, status };
};

$scope.GetAccessRole();

$scope.Allow = function () {
    if ($scope.Access.UserType == 'Admin' || !($scope.Status.Status == 'CC' || $scope.Status.Status == 'CD'))
        return true;
    return false;
}

Is your function GetAccessRole() returning the data you want? Keep console.log($scope.Access) there. — Surjeet Bhadauriya
– Surjeet Bhadauriya, Commented Dec 21, 2017 at 7:20
How can GetCurrentStatus and GetAccessRole are synchronous. You are using promises which made them async. By the time you are calling Allow(), you havent got your response. — Ashish
– Ashish, Commented Dec 21, 2017 at 7:23
Yes GetAccessRole() returns data. But $scope.Allow() executed before GetAccessRole() returns data. — ranjith babu
– ranjith babu, Commented Dec 21, 2017 at 7:23

Charlie · Accepted Answer · 2017-12-21 07:25:55Z

2

Although the functions $scope.GetCurrentStatus() and $scope.GetCurrentStatus() are called in a synchronous fasion, they have some asynchronous code in them.

Unfortunately your variable $scope.Access and $scope.Status are created only inside these asynchronous methods. So, it takes some waiting for a network response until the time comes to set your scope variables.

One workaround is to declare $scope.Access and $scope.Status somewhere upper in the controller.

$scope.Access = {};
$scope.Status = {};

answered Dec 21, 2017 at 7:25

Charlie

24k12 gold badges65 silver badges96 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dhananjay C · Accepted Answer · 2017-12-21 07:31:12Z

0

This is happening because you are using $scope.Allow before setting actual $scope.Access variable set by any value due to async call. So you can call $scope.Allow method inside defer success or set $scope.access and $scope.status before calling $scope.Allow method

   $scope.Access = {};
   $scope.Status = {};
   $scope.GetCurrentStatus() = function(){
       return $http.get('http://UR_URL');
   });
   $scope.GetAccessRole = function(){
       return $http.get('http://UR_URL');
   });

And use as

 $scope.GetCurrentStatus().then(function(response){
   $scope.Status = response.data.d;
 });
 $scope.GetAccessRole().then(function(response){
   $scope.Access = response.data.d;
 });

and then call $scope.Allow method

edited Dec 21, 2017 at 7:31

answered Dec 21, 2017 at 7:22

Dhananjay C

5979 silver badges36 bronze badges

Collectives™ on Stack Overflow

Setting variables from remote data in Angular JS

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related