Get web api response with HttpClient MVC

Question

I have an URL of API. I want to make an action in controller to get all data

BranchesController.cs:

 public Task<IEnumerable<BranchVm>> GetAllAsync()
    {
        string baseUrl = "http://api.diamond.smart-gate.net/api/Branches/GetBranches";
        var client = new HttpClient();
        var task = client.GetStringAsync(baseUrl);
        return task.ContinueWith<IEnumerable<BranchVm>>(innerTask =>
        {
            var json = innerTask.Result;
            return JsonConvert.DeserializeObject<BranchVm[]>(json);
        });
    }

Branch.js:

 columns: [
 {
    "data": 'branchArName',
    "name": "branchArName",
    "autoWidth": true,
    "orderable": true
   },
    {
   "data": 'branchEnName',
   "name": "branchEnName",
   "autoWidth": true,
   "orderable": true,
   },
 ],
   ajax: {
      url: "/Branches/GetAllAsync",
      dataSrc: ''
 }

It doesn't return any data but when I debug it , I have all data in innerTaslk.Result but var json equals null. so, I don't know why ?

This is working fine for me, how are you calling this method? — DavidG
– DavidG, Commented Dec 25, 2017 at 10:54
i use path of this method in js file ... when i debug i got var json = null :/ — Aya Abdelaziz
– Aya Abdelaziz, Commented Dec 25, 2017 at 10:56
Why not make the method properly async then? No need for the ContinueWith stuff. — DavidG
– DavidG, Commented Dec 25, 2017 at 10:57

DavidG · Accepted Answer · 2017-12-25 11:09:30Z

3

You're trying to do async code without using async. That method is much simpler if you use proper async syntax. This should solve problems with how you are calling it:

public async Task<IEnumerable<BranchVm>> GetAllAsync()
//     ^^^^^
//     Make the method async
{
    string baseUrl = "http://api.diamond.smart-gate.net/api/Branches/GetBranches";
    var client = new HttpClient();
    var json = await client.GetStringAsync(baseUrl);
    //         ^^^^^
    //         await the async call instead of messing around with tasks
    return JsonConvert.DeserializeObject<BranchVm[]>(json);
}

answered Dec 25, 2017 at 11:09

DavidG

120k13 gold badges232 silver badges239 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Get web api response with HttpClient MVC

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related