Optimizing object code

Question

I have 27 parts to my object, the first 2 are independent while the rest are just the same thing one after another. I am sure it can be optimized with a loop, however I am not sure how to approach this and if anyone can assist, I would be grateful.

Code below:

var BingoData = {Username: username, cardnumber: serial, Cell1: tablecells[0].innerHTML, Cell2: tablecells[1].innerHTML, Cell3: tablecells[2].innerHTML, Cell4: tablecells[3].innerHTML, Cell5: tablecells[4].innerHTML};

Names like Cell1, Cell2, Cell3, etc. beg for an array. — Code-Apprentice
– Code-Apprentice, Commented Dec 28, 2017 at 16:38

Chris Riebschlager · Accepted Answer · 2017-12-28 16:51:22Z

4

You could make Cells an array and populate it with a for loop.

var BingoData = {Username: username, cardnumber: serial, Cells: []};

for(let i = 0; i < tablecells.length; i++) {
    BingoData.Cells.push(tablecells[i].innerHTML);
}

edited Dec 28, 2017 at 16:51

answered Dec 28, 2017 at 16:34

Chris Riebschlager

1,3331 gold badge8 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Code-Apprentice Over a year ago

Cannot upvote this enough. Never, ever, ever use numbers in a variable name. Instead, just use an array.

EGxo Over a year ago

Why is i < 28? Should it not be less than 25 since I have 25 cells?

Chris Riebschlager Over a year ago

Yep! My typo... I changed it.

EGxo Over a year ago

And also what does let mean in this case and why to use it?

Jonas Wilms Over a year ago

No, no, no! It should neither be 25 nor 28 but rather tablecells.length !

|

Jonas Wilms · Accepted Answer · 2017-12-28 16:49:22Z

2

1) Identifiers that start with Capital letters are for constructors only

2) you may use an array for the cells

3) you may map the tablecells to their innerHTML property

 const bingo = {
   username,
   cardnumber: serial,
   cells: tablecells.map(cell => cell.innerHTML)
};

answered Dec 28, 2017 at 16:49

Jonas Wilms

139k20 gold badges164 silver badges164 bronze badges

Collectives™ on Stack Overflow

Optimizing object code

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related