laravel: odd behavior when query is empty

Question

I have a model

I call it this way:

Sight::filter(['type'=>'menu']);

and in model:

public function scopeFilter($query,$params)
{
    return $query
        ->wherePublish(1)
        ->whereIn_special(1)
        ->latest()
        ->first();
}

when there is one or more records, it works normally.

but when database is empty I get an odd behavior:

with dd(Sight::filter(['type'=>'menu']))

or

$query
        ->wherePublish(1)
        ->whereIn_special(1)
        ->latest()
        ->first();
        dd($query);

I got this result:

But with

dd(
$query
            ->wherePublish(1)
            ->whereIn_special(1)
            ->latest()
            ->first();
)

I got Null so it is right!

how can I return Null? what is my wrong?

Dwight · Accepted Answer · 2018-01-05 03:38:23Z

2

You shouldn't be calling first() inside of a scope - you are only meant to adjust the query by constraining it. You should call first() in your chain after applying the filter() scope. If you want to use the same syntax rather than chaining like that you would be best to define a custom static method.

public static function filter($params)
{
    return self::wherePublish(1)
        ->whereIn_special(1)
        ->latest()
        ->first();
]

Also note that in your example your scope accepts an argument (and you pass it one) but it isn't actually used in your code.

answered Jan 5, 2018 at 3:38

Dwight

12.5k6 gold badges53 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ali Over a year ago

Thanks, what about take() and paginate() ? They are invalid like first() in scope?

Dwight Over a year ago

take() is fine because again it's just adding constraints to the query. paginate() is not because like get() or first() it is actually performing the query.

Collectives™ on Stack Overflow

laravel: odd behavior when query is empty

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related