Taking random value from array - Javascript

Question

I've got array od values, and I want to take random from it. This is my code:

var bonus1='Opony zimowe';
var bonus2='Alarm';
var bonus3 = 'Bagażnik';
var bonus4 = 'Relingi';
var bonus5 = 'Box na narty';
var bonusy = [bonus1, bonus2, bonus3, bonus4, bonus5];
var pickBonus= bonusy[Math.floor(Math.random() * bonusy.length)];

But it doesn't show random value (Its always console.log - 'Alarm'):

What is wrong?

your code works, you're just printing the same pickBonus value over and over again... you need to run through the Math.random() part, to receive a new value. — David
– David, Commented Jan 10, 2018 at 8:55
Works fine for me. Perhaps there's a problem elsewhere in your code? — borkovski
– borkovski, Commented Jan 10, 2018 at 8:57

gurvinder372 · Accepted Answer · 2018-01-10 08:55:37Z

10

From your screenshot it appears that you are basically trying to print the same value multiple times expecting a different value.

It won't work, you need to get the random value again from the array every time. Make it into a function

 var pickBonus= () => bonusy[Math.floor(Math.random() * bonusy.length)];

And now invoke it as

console.log( pickBonus() );
console.log( pickBonus() );
console.log( pickBonus() );
console.log( pickBonus() );

Demo

var bonus1='Opony zimowe';
var bonus2='Alarm';
var bonus3 = 'Bagażnik';
var bonus4 = 'Relingi';
var bonus5 = 'Box na narty';
var bonusy = [bonus1, bonus2, bonus3, bonus4, bonus5];
var pickBonus= () => bonusy[Math.floor(Math.random() * bonusy.length)];

console.log( pickBonus() );
console.log( pickBonus() );
console.log( pickBonus() );
console.log( pickBonus() );

answered Jan 10, 2018 at 8:55

gurvinder372

68.6k11 gold badges78 silver badges98 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

gil.fernandes · Accepted Answer · 2018-01-10 08:59:11Z

2

pickBonus should be a function and not a variable in your case.

Then you can run this type of code and always get random values:

var bonus1 = 'Opony zimowe';
var bonus2 = 'Alarm';
var bonus3 = 'Bagażnik';
var bonus4 = 'Relingi';
var bonus5 = 'Box na narty';
var bonusy = [bonus1, bonus2, bonus3, bonus4, bonus5];

function pickBonus() {
  return bonusy[Math.floor(Math.random() * bonusy.length)];
}

console.log(pickBonus());
console.log(pickBonus());
console.log(pickBonus());
console.log(pickBonus());

answered Jan 10, 2018 at 8:59

gil.fernandes

14.8k7 gold badges78 silver badges87 bronze badges

Comments

Ashraful Islam · Accepted Answer · 2018-01-10 09:01:25Z

1

replace the last line

var pickBonus= bonusy[Math.floor(Math.random() * (bonusy.length-1)) + 1]

and wrap the whole code in a function to populate new pickBonus value in each function call

answered Jan 10, 2018 at 9:01

Ashraful Islam

1,26311 silver badges15 bronze badges

Collectives™ on Stack Overflow

Taking random value from array - Javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related