Firestore returning out of function and not appending any objects to array

Question

For some reason when i add the code if user.uid == uid {return} it will return out of the function altogether and not add any users to the array even though i only want to filter out the current user from being added to the array?

func fireStoreFetchUsers(){
    guard let uid = Auth.auth().currentUser?.uid else { return }
    let db = Firestore.firestore()

    db.collection("Users")
       .getDocuments() { (querySnapshot, err) in

          if let err = err {
            print("Error getting documents: \(err)")
          } else {
            for document in querySnapshot!.documents {
                let dictionary = document.data()
                let user = User2(uid: "", distanceFrom: "any", dictionary: dictionary)

                if user.uid == uid {return}

                self.users.append(user)               
                self.collectionView?.reloadData()
            }
        }
    }
}

That's what return means. It sounds like you want to continue. — Connor Neville
– Connor Neville, Commented Jan 17, 2018 at 13:07

David Pasztor · Accepted Answer · 2018-01-17 13:06:39Z

1

It seems that your problem in summary is that you want to skip a specific element of the array you are iterating through. This is exactly what continue does, so just change return to continue.

After the above change, the last two lines of the loop won't be executed when user.uid == uid and hence that specific user won't be added to the users array and the collectionView won't be reloaded, but the loop will continue its iteration with the next element rather than returning from the function.

for document in querySnapshot!.documents {
    let dictionary = document.data()
    let user = User2(uid: "", distanceFrom: "any", dictionary: dictionary)

    if user.uid == uid {continue}

    self.users.append(user)               
    self.collectionView?.reloadData()
}

answered Jan 17, 2018 at 13:06

David Pasztor

55.1k9 gold badges97 silver badges130 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user9043410 Over a year ago

Thanks David works as you know, has this always been like this as i swear the return code worked before i updated to the new firestore database?

David Pasztor Over a year ago

Yes, as far as I know, there was no change in the behaviour of Control Transfer Statements since Swift was introduced.

Collectives™ on Stack Overflow

Firestore returning out of function and not appending any objects to array

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related