What's a nicer way to do the following, that doesn't call f() twice?
$x = f() ? f() : 'default';
Add a comment
|
5 Answers
1 Comment
Andrew
+1 since I haven't seen that used in any of my books that cover PHP 5.3. Very good to know.
This seems to work fine:
$x = f() or $x = 'default';
Comments
function f()
{
// conditions
return $if_something ? $if_something : 'default';
}
$x = f();
1 Comment
dreeves
Ah, good answer. I meant for f() to be something we don't have control over and in fact the way this came up for me it wasn't a function at all but
$_REQUEST['foo'] so it wasn't an efficiency issue so much as a typing issue.$x = ($result = foo()) ? $result : 'default';
1 Comment
dreeves
This works, but it looks like it can be done more cleanly, with no temp variable.
You could save it to a variable. Testcase:
function test() {
echo 'here';
return 1;
}
$t = test();
$x = $t ? $t : 0;
echo $x;
