replicate preg replace with javascript

Question

Is it possible to replicate this with javascript?

preg_replace('/(.gif|.jpg|.png)/', '_thumb$1', $f['logo']);

EDIT - I am not getting this following error for this peice of code,

unterminated string literal

$('#feed').prepend('<div class="feed-item"><img src="'+html.logo.replace(/(.gif|.jpg|.png)/g, "_thumb$1")+'"/> <div class="content">'+html.content+'</div></div>').fadeIn('slow');

By replication do mean that you want the same errors that the original code has? — Mark Byers
– Mark Byers, Commented Jan 28, 2011 at 21:04
To be strictly correct you should use \.jpe?g in both. The short jpg variant is just a concession to the DOS era. — mario
– mario, Commented Jan 28, 2011 at 21:12

Mark Byers · Accepted Answer · 2011-01-28 21:25:00Z

6

There are a couple of problems with the code you are trying to replicate:

It matches "extensions" even if they aren't at the end of the filename.
The dot in a regular expression matches (nearly*) any character, not just a period.

Try this instead:

'abc.jpg'.replace(/\.(jpg|gif|png)$/, '_thumbs$&')

I'm assuming that the string you are trying to replace contains only a single filename.

*See the documentation for PCRE_DOTALL.

edited Jan 28, 2011 at 21:25

answered Jan 28, 2011 at 21:06

Mark Byers

844k202 gold badges1.6k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

NikiC Over a year ago

Would be even nicer if you dropped the outer capturing group and used $&. +1

Mark Byers Over a year ago

@nikic: +1 Nice, thanks! I completely forgot you can do that in Javascript. :)

sdleihssirhc · Accepted Answer · 2011-01-28 21:04:57Z

3

Yes, except that in JavaScript, replace is a string's method, so it would be rearranged a little (also, the array/object notation is slightly different):

f.logo.replace(/\.(gif|jpg|png)/, '_thumb.$1');

more info

answered Jan 28, 2011 at 21:04

sdleihssirhc

42.6k6 gold badges56 silver badges67 bronze badges

6 Comments

sdleihssirhc Over a year ago

@nikic When would an image's filename include a period and the extension more than once?

NikiC Over a year ago

@sdleihssirhc: Damned, you are obviously right. I always make the mistake of forgetting that modifier and now I see that mistake even if it isn't a mistake... +1 for pointing out.

mario Over a year ago

It's not completely impossible that a filename contains two extensions. It would be retarded, yes. But it's technically allowed and HTTP content negotiation schemes could indeed use a redundant img0011.pnga.en.png. Thus I would also avoid the $ anchor but append \b instead.

user557597 Over a year ago

@sdleihssirhc - Happens all the time in windows "file.gif.txt.jpg". Technically your missing the $ anchor.

sdleihssirhc Over a year ago

@mario By avoiding the $, do you mean end of string or the $1 that I used?

|

Marc B · Accepted Answer · 2011-01-28 21:03:00Z

0

somestringvar.replace(/(.gif|.jpg|.png)/, replacementValue)

answered Jan 28, 2011 at 21:03

Marc B

362k44 gold badges433 silver badges508 bronze badges

Collectives™ on Stack Overflow

replicate preg replace with javascript

3 Answers 3

2 Comments

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related