How can i refactor this Ruby, Rails code?

Question

I'm new at Rails... Is there a better way to refactor this code:

  def get_product_price_minimum
    Product.minimum(:price).to_i
  end

  def get_product_price_maximum
    Product.maximum(:price).to_i
  end

What is the purpose of this two methods, so I can give solution based on purpose. e.g. you want minimum price product — ashvin
– ashvin, Commented Jan 20, 2018 at 12:26
Why are those two methods a problem? Sure, you could mash them together but to what end? Would refactoring make the code easier to read? Easier to use? Easier to debug? Easier to test? Faster? Maybe move them to class methods on Product and call it a day. Refactoring is great but there's not enough there to make it worthwhile (IMO). — mu is too short
– mu is too short, Commented Jan 20, 2018 at 19:35

Sebastián Palma · Accepted Answer · 2018-01-20 15:16:37Z

2

You can define something like "prices" (a vague method name, to avoid using get_ or set_ prefixes) to expect an argument, which would be the maximum or minimum for which to query your model:

def prices(what)
  Product.public_send(what, :price).to_i
end

Then you can use it by passing the minimum or maximum as a symbol or a string.

edited Jan 20, 2018 at 15:16

answered Jan 20, 2018 at 14:05

Sebastián Palma

33.6k6 gold badges45 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user9202590 · Accepted Answer · 2018-01-20 12:22:52Z

0

I'm not sure your function works but you can try (if price is column and price is a int not a string)

def get_product_price_minimum
      Product.order('price').last
end

answered Jan 20, 2018 at 12:22

user9202590

1 Comment

Sergio Tulentsev Over a year ago

what about maximum?

Collectives™ on Stack Overflow

How can i refactor this Ruby, Rails code?

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related