Check every property with condition using every es6 for object

Question

I'm using react and I have state like this

this.state = {
  form: {
    name: {required: true, filled: false, value: ''},
    age: {required: true, filled: false, value: ''},
    dob: {required: false, filled: false, value: ''}
  }
}

I want to check if every form field has been filled, I tried this

const formValid = Object.keys(this.state.form).filter(o=>{
  return o.required
}).every(o=> {
  return o.filled!==null && o.filled!==''
})

I know this is wrong because Object.keys just return the key, I wish the state is array it will make my life much easier, but what if I don't want to change the structure of the state? How do I do it?

synthet1c · Accepted Answer · 2018-01-21 12:19:24Z

1

I would use Array#every with Object.keys

With Object.keys you can get the value by referencing the object that it belongs to eg. this.state.form[key]

const formValid = 
  Object.keys(this.state.form)
    .every(key => (
      this.state.form[key].required && 
      this.state.form[key].filled !== null && 
      this.state.form[key].filled !== ''
    ))

if you need a reference to the failures I would change every to filter

answered Jan 21, 2018 at 12:19

synthet1c

6,3024 gold badges28 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Thian Kian Phin Over a year ago

this make sense too why I keep thinking every is for array only.

synthet1c Over a year ago

it is for an array only. using Object.keys gets the objects keys as an array. then in the every callback we are getting the value from the object explicitly.

Bary12 · Accepted Answer · 2018-01-21 12:15:45Z

1

Use Object.values(this.state.form) instead. This returns an array of the values instead of the keys.

answered Jan 21, 2018 at 12:15

Bary12

1,0889 silver badges23 bronze badges

Comments

Zlatko · Accepted Answer · 2018-01-21 12:16:26Z

1

You can map over object keys.

const formValid = Object.keys(this.state.form)
    // map the keys to their values.
    .map(key => this.state.form[key])
    .filter(o => o.required)
    ...

Edit: But if all you want is the values, then the other answer is better.

edited Jan 21, 2018 at 12:16

answered Jan 21, 2018 at 12:13

Zlatko

19.7k14 gold badges76 silver badges130 bronze badges

3 Comments

Bary12 Over a year ago

Why not just Object.values?

Thian Kian Phin Over a year ago

@Zlatko what do you mean by slow? so the correct solution should be using Object.values?

Zlatko Over a year ago

Yep. I mean, they are both correct and produce the same result. But Object.values is simpler and shorter.

Collectives™ on Stack Overflow

Check every property with condition using every es6 for object

3 Answers 3

2 Comments

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related