stringByEvaluatingJavaScriptFromString not working

Question

This expression doesn't seem to work. It's with a Mac application, not an iPhone app.

[[mainWebView mainFrame] stringByEvaluatingJavaScriptFromString:[NSString stringWithFormat:@"document.getElementById('username').value='%@';document.getElementById('password').value='%@';", [ebuddyidField value], [passwordField value]]];

Peter Hosey · Accepted Answer · 2011-01-29 23:30:39Z

3

You need to send your stringByEvaluatingJavaScriptFromString: message to the WebView, not to its main frame.

Also, assuming that ebuddyidField and passwordField are NSTextFields (the latter possibly an NSSecureTextField), they do not respond to a value message. The closest message they do respond to is objectValue, though you more probably want stringValue.

The compiler should have given you warnings for all three problems. Go to your Build Results window and fix every warning. Then turn some more on and fix those, too. Your application will be much more stable, more robust, and less leaky for it.

answered Jan 29, 2011 at 23:30

Peter Hosey

96.5k15 gold badges214 silver badges373 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

icant Over a year ago

Thanks for the stringValue part, I always forget that. But it doesn't give me any warnings anymore and still it isn't working...

Peter Hosey Over a year ago

@icant: Then you need to edit your question both to show your revised code and to be more specific about how it “isn't working”.

Jonathan Grynspan · Accepted Answer · 2011-01-30 09:52:54Z

0

That's because WebFrame doesn't respond to -stringByEvaluatingJavaScriptFromString:. That's a method of UIWebView on iOS, and has nothing to do with WebKit on Mac OS X.

Try [[webView windowScriptObject] evaluateWebScript:...] instead. The result of that method, however, is an id, and its type may or may not be NSString.

See the WebScriptObject class documentation for more info on JavaScript interaction in WebKit on Mac OS X.

Edit: Actually, going back and looking at the WebView docs, I see it does indeed have a -stringByEvaluatingJavaScriptFromString: method. So try sending that to the web view rather than the web frame.)

edited Jan 30, 2011 at 9:52

answered Jan 29, 2011 at 22:11

Jonathan Grynspan

43.5k8 gold badges76 silver badges105 bronze badges

4 Comments

icant Over a year ago

It says 'No -evaluateWebScript: method found'. This is my code: [[mainWebView windowScriptObject] evaluateWebScript:[NSString stringWithFormat:@"document.getElementById('username').value='%@';document.getElementById('password').value='%@';", [ebuddyidField value], [passwordField value]]];

Jonathan Grynspan Over a year ago

Did you #import <WebKit/WebKit.h>?

icant Over a year ago

Yes, I did import it in the header file.

Jonathan Grynspan Over a year ago

In any case, @Peter has the right answer-- send -stringByEvaluatingJavaScriptFromString: to the WebView rather than the WebFrame. That should cover it.

Collectives™ on Stack Overflow

stringByEvaluatingJavaScriptFromString not working

2 Answers 2

2 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related