Log DbContext.SaveChanges Exception to the database in Entity Framework/Entity Framework Core

Question

In my asp.net core web application, I am logging the exceptions to the database.Till now everything works fine but problem is that when the DbConext.SaveChanges in try block throws an exception, cannot log the exception to the database as DbConext.SaveChanges in catch block also throws the same exception.

Here is the code I have tried so far :

try
{
    _unitOfWork.Repository<Product>().InsertEntity(product);
     await _unitOfWork.SaveChangesAsync();//This throws exception due the model validation failure
}
catch (Exception exception)
{
    ExceptionModel exceptionModel = new ExceptionModel();
    using (MyDbContext dbContext = new MyDbContext())
    {
        await dbContext.ExceptionModels.AddAsync(exceptionModel);
        await dbContext.SaveChangesAsync(); // Throws the same exception that was thrown in try block due to entity framework transaction
    }
}

Note: I guess the problem is causing due to the Entity Framework transaction.

Please help how can I overcome this situation to log the exception to the database. Thanks!

Let's say you failed to save changes to a database because the database server is down. Now you want to log something to the database to indicate that the first save failed. What do you expect to happen? — mjwills
– mjwills, Commented Feb 20, 2018 at 8:30
Use some external service such as Exceptionless and don't do try/catch. Logging db errors into the same db sounds like a bad idea. — illug
– illug, Commented Feb 20, 2018 at 9:33

k2ly2n · Accepted Answer · 2018-05-14 03:05:50Z

2

In try block you are adding some changes to db context. While saving you got some exception and using the same db context in catch block to log that exception. Here the db context still has unsaved changes made in try block. So you will get the same exception while saving the context.

To avoid this you have to discard the changes from db context in catch block before adding more changes.

private void ResetContextState() => _context.ChangeTracker.Entries()
.Where(e => e.Entity != null && e.state == EntityState.Added).ToList()
.ForEach(e => e.State = EntityState.Detached);

Edit: the above code worked for me.

edited May 14, 2018 at 3:05

answered May 11, 2018 at 16:54

k2ly2n

314 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dbc · Accepted Answer · 2024-04-23 14:25:24Z

2

In all versions of Entity Framework, whenever you execute SaveChanges() to insert, update or delete on the database, the framework will wrap the operation in a transaction. This transaction lasts long enough to execute the operation and then commits.

this is all I did after catching a sql exception on SaveChangesAsync and it works great in core 6. I was able to create a new log record and insert it using the same context after just one line which detaches all entities. They are still there in error state so that is why you can't continue without detaching.

_context.ChangeTracker.Clear();

edited Apr 23, 2024 at 14:25

dbc

120k27 gold badges273 silver badges404 bronze badges

answered Apr 23, 2024 at 12:20

Joe

1,67912 silver badges10 bronze badges

Comments

TanvirArjel · Accepted Answer · 2018-09-23 03:52:11Z

In Entity framework Core, I have solved the problem easily using EF-Core Transaction

try
{
    _unitOfWork.Repository<Product>().InsertEntity(product);
     await _unitOfWork.SaveChangesAsync();//This throws exception due the model validation failure
}
catch (Exception exception)
{
    ExceptionModel exceptionModel = new ExceptionModel();

    string connectionString = _configuration.GetConnectionString("MyConnection");

    var options = new DbContextOptionsBuilder<MyDbContext>()
                .UseSqlServer(new SqlConnection(connectionString))
                .Options;

    using (var dbContext = new MyDbContext(options))
    {
         using (var transaction = dbContext.Database.BeginTransaction())
         {
             try
             {
                   dbContext.Exceptions.Add(exceptionModel);
                   await dbContext.SaveChangesAsync();
                   transaction.Commit();
             }
             catch (Exception e)
             {
                 Console.WriteLine(e);
                 throw;
             }
         }
     }
}

Collectives™ on Stack Overflow

Log DbContext.SaveChanges Exception to the database in Entity Framework/Entity Framework Core

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related