Unhandled Exception When Executing SQL Server INSERT

Question

I have written code in C# and integrated it with SQL Server, but each time I run it I keep getting this error:

System.Data.SqlClient.SqlException: 'Incorrect syntax near ';'.'

My code is this:

private void btnsubmit_Click(object sender, EventArgs e)
{
    var connectiontring =
        ConfigurationManager.ConnectionStrings["connData"].ConnectionString;

    string querystring = "INSERT INTO [Table] VALUES(@Name, @Gender, @Age, @Course, @Department, @Program, @Address, @PostCode, @Email;";

    using (var connection = new SqlConnection(connectiontring))
    {
        var cmd = new SqlCommand(querystring, connection);
        connection.Open();

        cmd.Parameters.AddWithValue("Name", tblName.Text);
        ...
        cmd.Parameters.AddWithValue("Email", tbllMail.Text);

        cmd.ExecuteReader();

        tblName.Text = "";
        ...
        tbllMail.Text = "";
    }
}

Please note that it's always recommended to include column names in insert statements: insert into [Table] (Name, Gender, Age...) VALUES (@Name, @Gender, @Age...). Also, SqlCommand is an IDisposable, and also, Can we stop using AddWithValue() already? — Zohar Peled
– Zohar Peled, Commented Feb 25, 2018 at 10:04

Marc Gravell · Accepted Answer · 2018-02-25 09:56:44Z

3

SQL Server is right. Add a closing paren after the list of values:

string querystring = "insert into [Table] VALUES(@Name, ..., @Email);";

answered Feb 25, 2018 at 9:56

Marc Gravell

1.1m273 gold badges2.6k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Zoran Horvat · Accepted Answer · 2018-02-25 09:56:44Z

2

You have a ; in the query string in place where ) should appear. Correct query string is:

 string querystring = 
    "insert into [Table] VALUES " +
    "   (@Name, @Gender, @Age, @Course, @Department, @Program, " +
    "    @Address, @PostCode, @Email)";

answered Feb 25, 2018 at 9:56

Zoran Horvat

11.4k3 gold badges36 silver badges45 bronze badges

Collectives™ on Stack Overflow

Unhandled Exception When Executing SQL Server INSERT

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related