Fetching html form values

Question

The following javascript code is for a "ping-pong" game I was asked to make:

var final_number = document.getElementById("input").value;
var current_number = 0;

var interval = setInterval(document.getElementById("submit").onclick = function() {
    document.getElementById('number').innerHTML = ++current_number;
    if (current_number % 3 === 0){
        document.getElementById('number').innerHTML = "ping";
    }
    if (current_number % 5 === 0){
        document.getElementById('number').innerHTML = "pong";
    }   
    if (current_number % 15 === 0){
        document.getElementById('number').innerHTML = "ping";
        document.getElementById('number').innerHTML = "pong";
    }    
    if (current_number >= final_number){
        document.getElementById('number').innerHTML = 'Game Over';
        clearInterval(interval);
    }
}, 1000);

It counts up from 0 to the number inputted in the form "input" in the html then says 'Game Over' when it reaches the number. The problem, however, is that it immediately says 'Game Over' without counting at all. I think the problem is with fetching the form value. It worked until iI introduced the variable "final_number" and put it in the last if statement (I used the number 50 before). Any ideas how to fix this?

You could use a debugger to actually see what's going on.

Uwe Keim
– Uwe Keim

2018-02-25 15:29:29 +00:00
Commented Feb 25, 2018 at 15:29 — Uwe Keim
– Uwe Keim, Commented Feb 25, 2018 at 15:29

Leonardo Gazdek · Accepted Answer · 2018-02-25 15:31:16Z

3

You need to use parseInt when getting the value, otherwise it will be a string

var final_number = parseInt(document.getElementById("input").value,10);

answered Feb 25, 2018 at 15:31

Leonardo Gazdek

3302 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Yuuuucef · Accepted Answer · 2018-02-25 15:33:04Z

1

You are comparing a number with a Text so its comparing ASCII values , I think that you need to convert your value first

answered Feb 25, 2018 at 15:33

Yuuuucef

712 silver badges12 bronze badges

Collectives™ on Stack Overflow

Fetching html form values

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related