I've got a computed method that allows me to count a total price of my products and discount value and would like to get the value of: total - discount.
cartTotal() {
var total = 0;
var discount = Math.round((0.1 * this.cartTotal) * 100) / 100;
this.cart.items.forEach(function(item) {
total += item.quantity * item.product.price;
});
total -= discount;
return total;
}
Doens't work for me and I get that Maximum call stack size exceeded error.
You're getting that error because you have two computed properties that reference each others' value. Whenever you do that, you create a cyclical dependency which will generate a "Maximum call stack size exceeded" error.
You really have three values you're dealing with 1) a sum of all values in the cart, 2) a discount amount, and 3) a total value which is the sum minus the discount.
You should have three computed properties:
computed: {
cartSum() {
return this.cart.items.reduce((n, i) => n += i.quantity * i.product.price, 0);
},
discountValue() {
return Math.round((0.1 * this.cartSum) * 100) / 100;
},
cartTotal() {
return this.cartSum - this.discountValue;
},
}
this.discountValue.discountto call yourdiscountValue()method?discountValue.discountmakes no sense (neither does settingdiscountActive = truethen immediately throwing it away). What are you trying to do?discountValue()seems to assume thatcartTotal()returns a price without the discount subtracted from it, but then incartTotal()you want to subtract the discount from it. There is a logical error here. You must make up your mind: doescartTotal()include the discount or not?total.