Get variable from link in PHP, issue

Question

I have URL below:

session.php?action=create_program

Then I have the following piece of code:

if( isset($_GET['action']) ){ $action= $_GET['action']; $action=''; }

It returns an empty string while it should return ''create_program'

I check the condition, if the $_GET is not set then I set it to empty, otherwise it should be equal to the $_get — Dani M
– Dani M, Commented Mar 2, 2018 at 11:21

Federico klez Culloca · Accepted Answer · 2018-03-02 13:01:03Z

5

I think you were trying to set it to empty if you didn't receive anything in your get request. So either do it like this

if( isset($_GET['action']) ){
    $action= $_GET['action'];
} else {
    $action='';
}

Or, even simpler, give a default value that remains set if the get parameter is absent.

$action = '';
if( isset($_GET['action']) ){
    $action= $_GET['action'];
}

Finally, as suggested by Cashbee in the comment below, you can use the ternary operator to check whether $_GET['action'] was set and, in case it's not, give a default value to $action.

$action = isset($_GET['action']) ? $_GET['action'] : '';

edited Mar 2, 2018 at 13:01

answered Mar 2, 2018 at 11:26

Federico klez Culloca

27.3k17 gold badges61 silver badges102 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

kscherrer Over a year ago

You could even shorten that with ternary operator: $action = isset($_GET['action']) ? $_GET['action'] : '';

Markus Zeller · Accepted Answer · 2018-03-02 11:57:23Z

2

Easy is the use of the ternary operator like this:

$action = isset($_GET['action']) ? $_GET['action'] : '';

You should always check if the variable is set or empty.

$action = empty($_GET['action']) ? '' : $_GET['action'];

Or even better, use the PHP filter functions.

$action = filter_input(INPUT_GET, 'action');

This has the advantage, you can even use rules, to give the appropriate result, like described in http://php.net/manual/de/function.filter-input.php

answered Mar 2, 2018 at 11:57

Markus Zeller

9,2142 gold badges34 silver badges39 bronze badges

Comments

Zain Farooq · Accepted Answer · 2018-03-02 11:27:27Z

1

You are setting $action to empty at last that's why it is returning an empty string

if( isset($_GET['action']) )
{
  $action= $_GET['action'];
// $action='';  //Just remove this code
}

edited Mar 2, 2018 at 11:27

answered Mar 2, 2018 at 11:21

Zain Farooq

2,9664 gold badges23 silver badges49 bronze badges

Comments

JoinCompany · Accepted Answer · 2018-03-02 12:05:59Z

1

//$action will be empty if not have $_GET['action'];, just for PHP7
$action = $_GET['action'] ?? '';

hope can help you!

edited Mar 2, 2018 at 12:05

answered Mar 2, 2018 at 11:23

JoinCompany

5142 silver badges11 bronze badges

2 Comments

Dani M Over a year ago

Thank you, but when I echo the $action, then I get 1

Jonnix Over a year ago

Did you mean ??? Or perhaps ?:?

Collectives™ on Stack Overflow

Get variable from link in PHP, issue

4 Answers 4

1 Comment

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related