For loop doesn't end using Node.js

Question

I have this simple code:

File app.js:

var cheerio = require('cheerio');
var express = require('express');
var fs = require('fs');
var request = require('request');

var downloader = require('./routers/downloader.js');

const app = express();

downloadAll();

function downloadAll() {
    downloader.test();
}

File downloader.js:

var cheerio = require('cheerio');
var express = require('express');
var fs = require('fs');
var request = require('request');
var methods = {};

methods.test = function(req, res) {
    for(var i = 1; 10; i++) {
        console.log(i); // DOESN'T WORK
    }

    var obj;
    fs.readFile('./output/ita-2015-24m.json', 'utf8', function(err, data) {
        if(err) {
            throw err;
        }
        obj = JSON.parse(data);
        console.log(obj); 
    }
}

module.exports = methods;

When I run app.js using node app.js, I get: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, .... The loop doesn't end.

I try to change position to this loop, interting it inside readFile function but it's the same problem.

My goal is iterate throug obj object.

Why? How can I solve?

Your var methods = {}; is a variable that hold the value of an empty object. You should use a for in loop (watch out for non-enumerable properties) instead of testing your code with a for loop — rags2riches-prog
– rags2riches-prog, Commented Mar 7, 2018 at 14:46

gurvinder372 · Accepted Answer · 2018-03-07 14:26:02Z

6

When I run app.js using node app.js, I get: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, .... The loop doesn't end.

Your loop doesn't have end-condition, hence it will keep on incrementing i

Make it

for(var i = 1; i <= 10; i++) {
    console.log(i); // DOESN'T WORK
}

answered Mar 7, 2018 at 14:26

gurvinder372

68.6k11 gold badges78 silver badges98 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

upsidedowncreature · Accepted Answer · 2018-03-07 14:27:00Z

1

You've written for(var i = 1; 10; i++)

The loop will never end because 10 is always true (or at least never false). Should be something like:

for(var i = 1; i<10; i++)

answered Mar 7, 2018 at 14:27

upsidedowncreature

6274 silver badges12 bronze badges

Comments

Yahya · Accepted Answer · 2018-03-07 14:28:18Z

0

Instead of:

for(var i = 1; 10; i++)

Try:

for(var i = 1; i <= 10; i++)

answered Mar 7, 2018 at 14:28

Yahya

7468 silver badges24 bronze badges

Comments

na3na3iss · Accepted Answer · 2018-03-07 15:39:02Z

0

if you want 10 elements you can use

for(var i = 1; i<= 10; i++)

or

for(var i = 0; i< 10; i++)

answered Mar 7, 2018 at 15:39

na3na3iss

651 gold badge1 silver badge10 bronze badges

Collectives™ on Stack Overflow

For loop doesn't end using Node.js

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related