JavaScript Pop vs slice methods on an array

Question

I've got a data set that's several hundred elements long. I need to loop through the arrays and objects and determine if the data in them is less than a certain number (in my case, 0). If it is, I need to remove all those data points which are less than zero from the data set.

I've tried .pop and .slice but I'm not implementing them correctly. I was trying to push the bad data into its own array, leaving me with only the good data left.

Here's my JS

for (var i = 0; i < data.length; i++) {
    if (data[i].high < 0) {
       console.log(data[i].high)
       var badData = [];
       badData.push(data.pop(data[i].high));
       console.log(data[i].high)
   }  
}

.pop() does not accept any arguments. It simply pops off the last element in the array. It seems like you are looking for .splice() instead, so you can remove an element at a specific index, yes? — mhodges
– mhodges, Commented Mar 9, 2018 at 18:13

Andrew Heekin · Accepted Answer · 2018-03-09 18:14:27Z

6

I'd go with .filter():

const result = data.filter(row => row.high > 0);

answered Mar 9, 2018 at 18:14

Andrew Heekin

6711 gold badge6 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

mhodges Over a year ago

OP wants the "bad" data (aka < 0) in a separate array. This also does not account for row.high == 0, which should be valid.

Andrew Heekin Over a year ago

No, that's not the question that was asked, that was just one approach that was considered

mhodges Over a year ago

"I was trying to push the bad data into its own array"

Ryan Wilson Over a year ago

@AndrewHeekin Updated my comment, .filter() is better suited for this. +1 for you good sir.

J.G.Sable Over a year ago

@AndrewHeekin This works perfectly! You're a rockstar.

|

sandrooco · Accepted Answer · 2018-03-09 18:19:30Z

4

In case you need the bad results too.

const { good, bad } = data.reduce((acc, row) => {
    const identifier = row.high > 0 ? 'good' : 'bad';
    acc[identifier].push(row);
    return acc;
}, { bad: [], good: [] });

answered Mar 9, 2018 at 18:19

sandrooco

8,88611 gold badges56 silver badges101 bronze badges

2 Comments

Joe Warner Over a year ago

Interesting approach :)

Patrick Roberts Over a year ago

Don't forget the ugly

Collectives™ on Stack Overflow

JavaScript Pop vs slice methods on an array

2 Answers 2

8 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related