javascript - string replace

Question

Not sure why but i can't seem to replace a seemingly simple placeholder.

My approach

var content = 'This is my multi line content with a few {PLACEHOLDER} and so on';
content.replace(/{PLACEHOLDER}/, 'something');
console.log(content); // This is multi line content with a few {PLACEHOLDER} and so on

Any idea why it doesn't work?

Thanks in advance!

you need to store the result of replace somewhere : try this : var content = 'this is {placeholder}'; content = content.replace(/{placeholder}/,'something'); alert(content); should work — Shrinath
– Shrinath, Commented Feb 7, 2011 at 11:01

Jonny Buchanan · Accepted Answer · 2011-02-07 11:10:34Z

17

Here's something a bit more generic:

var formatString = (function()
{
    var replacer = function(context)
    {
        return function(s, name)
        {
            return context[name];
        };
    };

    return function(input, context)
    {
        return input.replace(/\{(\w+)\}/g, replacer(context));
    };
})();

Usage:

>>> formatString("Hello {name}, {greeting}", {name: "Steve", greeting: "how's it going?"});
"Hello Steve, how's it going?"

answered Feb 7, 2011 at 11:10

Jonny Buchanan

62.9k17 gold badges147 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

typo.pl · Accepted Answer · 2011-02-07 10:55:14Z

10

JavaScript's string replace does not modify the original string. Also, your code sample only replaces one instance of the string, if you want to replace all, you'll need to append 'g' to the regex.

var content = 'This is my multi line content with a few {PLACEHOLDER} and so on';
var content2 = content.replace(/{PLACEHOLDER}/g, 'something');
console.log(content2); // This is multi line content with a few {PLACEHOLDER} and so on

answered Feb 7, 2011 at 10:55

typo.pl

8,9302 gold badges30 silver badges29 bronze badges

Comments

user517400 · Accepted Answer · 2011-02-07 10:53:42Z

2

Try this way:

var str="Hello, Venus";
document.write(str.replace("venus", "world"));

answered Feb 7, 2011 at 10:53

user517400

Collectives™ on Stack Overflow

javascript - string replace

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related