Codeigniter returning non-object

Question

I have this happen all the time and I'm never quite sure why it's happening. Here is the query in my model:

$query = $this->db->query('SELECT * FROM members WHERE email = "' . $this->session->userdata('email') . '"');
        return $query;

I try to output this in my view with:

foreach($query->result() as $row) {...echo $row->name, etc.}

But I get an error:

Fatal error: Call to a member function result() on a non-object ...

I ran the profiler and my query is valid and there is data in the database to be pulled. So what am I do wrong?

No offense, jondavidjohn, but the solution was different. See the differences between the two accepted solutions. — sehummel
– sehummel, Commented Feb 8, 2011 at 15:57

Dwayne Charrington · Accepted Answer · 2011-02-08 02:14:47Z

3

Try this.

In your model:

function get_members()
{
    $query = $this->db->query('SELECT * FROM members WHERE email = "' . $this->session->userdata('email') . '"');
    return $query->result();
}

In your controller:

You should then be assigning the data from the database in your controller to your view like so.

$data['query'] = $this->yourmodel->get_members(); // Data['query'] will be turned into $query in your view.

$this->load->view('mytemplate', $data);

In your view:

foreach($query as $row) {...echo $row->name, etc.}

answered Feb 8, 2011 at 2:14

Dwayne Charrington

6,6428 gold badges43 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Finbarr · Accepted Answer · 2011-02-08 00:03:21Z

0

If you are passing the $query variable to the view, codeigniter will convert it into a keyed array if it is an object.

http://codeigniter.com/user_guide/general/views.html

Note: If you use an object, the class variables will be turned into array elements.

Edit:

In your controller:

$query = // do whatever to get the $query.
$members = array();
foreach($query->result() as $row) {
    $members[] = $row;
}
//send $members to view

In view:

foreach($members as $member) {
    echo $member['name']; // etc
}

edited Feb 8, 2011 at 0:03

answered Feb 7, 2011 at 23:37

Finbarr

32.3k13 gold badges67 silver badges94 bronze badges

3 Comments

sehummel Over a year ago

So how do I not do that? I have some similar code to this and it works fine. What is the proper thing to do. Newbie here.

Finbarr Over a year ago

You should execute the query inside of the model or the controller and instead pass an array of model objects or values to the view. The view should just be a dumb data displayer.

sehummel Over a year ago

How do I do that? Sorry for my ignorance.

Collectives™ on Stack Overflow

Codeigniter returning non-object

2 Answers 2

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related