PHP call class variable / property with stored closure

Question

So I am making a Magento module in PHP. I want my logging to be consistent across all classes. My idea was to define a method in the helper class and call it. However being the pre-optimizer that I am, I figure making multiple calls to a class via the Mage::Helper() method to be more expensive than it needs to be, especially since most of my logging in singleton models anyways. So my now my idea is to use closures, define my method in the helper, make one call to the helper and register the method in a class variable.

class Comp_Mod_Helper_Data extends Mage_Core_Helper_Abstract {
    public function getLogger() {
        return function ($obj, $type= Zend_Log::DEBUG) {
             Mage::log($obj, $logType, 'comp-mod.log', true);
        };
    }       
}

Use:

class Comp_Mod__IndexController extends age_Core_Controller_Front_Action {
    private $_log;
    protected function _construct() {
        $this->_log = Mage::Helper('mod')->getLogger();
    }
}

However while it works ... it is not great to use. I'm either stuck doing:

$log = $this->_log;
$log('hello world');
// one awkward liner
($this->_log)('hello world');

While neat that it works is not readable nor standard, i.e. confusing!. The error that it get when using $this->_log('hello world'); is that the method does not exist. I assume because PHP is looking for a method call when using the syntax $this->method();

I do understand that A) I could just suck it up and use Mage::Helper everywhere, and B) that I could store the helper object in a variable and call like $this->helper->log(), and C) that static variables work, see PHP closure as static class variable

So, is there a way to get a non-static class variable to call the closure instead of looking for a non-existing method?

So I'm not familiar with Magento so my question might be dumb, but why return a closure in that Comp_Mod_Helper_Data method instead of having a simple log method that would call Mage::log? Then you'd do $helper = Mage::Helper('mod'); $helper->log(...) (can also probably store the helper instance in a controller property) — Jeto
– Jeto, Commented Mar 16, 2018 at 23:11
@Jeto, thanks for the comment. I do realize that I can do that. I mention in my second to last paragraph that there are acceptable workarounds. My question is more about the language and how it works rather than the design of it. — Henry Nitz
– Henry Nitz, Commented Mar 17, 2018 at 1:13
I did miss the B) part of that paragraph, sorry about that. I'll give it another read/thought later today if no one has helped you by then. — Jeto
– Jeto, Commented Mar 17, 2018 at 1:19

Jeto · Accepted Answer · 2018-03-17 01:41:50Z

0

You could make use of the __call magic method:

class Comp_Mod__IndexController extends age_Core_Controller_Front_Action {

    public function __call($method, array $args)
    {
        switch ($method)
        {
            case '_log':
                return call_user_func_array(Mage::Helper('mod')->getLogger(), $args);
        }

        return null;
    }
}

Then use it like you wanted to:

$this->_log('string to log');

answered Mar 17, 2018 at 1:41

Jeto

15k2 gold badges39 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP call class variable / property with stored closure

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related