Java GUI is being created, but event is not triggering anything

Question

I am trying to create this simple GUI where the number of clicks is displayed on the button and incremented after each click, and so that after each click, the colours of each button are rotated one value to the right. At the moment, the GUI is created, but the background is not set and nothing happens when you click on anything. I can't seem to find a problem here. Can anyone see any ?

Thanks a lot for your help with this :)

 import java.awt.*;
    import javax.swing.*;
    import java.awt.event.*;


public class ButtonJava extends JButton implements ActionListener  {
  private static int currentColor=0;
  private int clicks;
  private static final Color[] COLORS = {
    Color.ORANGE,
    Color.WHITE,
    Color.GREEN };

  public ButtonJava( ){
    setBackground( Color.YELLOW );
    setText( "Pick ME" );
    this.addActionListener( this );
  }

  public static void main(String[] args) {
    JFrame frame = new JFrame ("JFrame");
    JPanel panel = new JPanel( );
    frame.setDefaultCloseOperation( JFrame.EXIT_ON_CLOSE);
    JButton buttons[] = new JButton[3];
    for(int i = 0;i<buttons.length ; i++){
      buttons[i] = new ButtonJava(); 
      panel.add(buttons[i]);
    }
    frame.getContentPane( ).add( panel );
    frame.setSize( 500, 500);
    frame.setVisible( true );
  }

  private void updateButton() {
    changeColors();
    clicks++;
    setText( "# of clicks = " + Integer.toString(clicks) );
  }

  private void changeColors( ) {
    for (int i=0;i<COLORS.length;i++){
      setBackground(COLORS[currentColor]);
      currentColor %=2;
    }
  }

  @Override
  public void actionPerformed( ActionEvent event ) {
    updateButton( );   
  }


}

Ah, I have rectified my initial mistake now, but I have implemented the call to changeColors() incorrectly, it is only changing the color of one button rather than all three. Can anyone help please ? — user476033
– user476033, Commented Feb 8, 2011 at 20:50
@user476033: Each ButtonJava object only has control of itself, which means when you click on one of the buttons, only that button will change color. If you want to click on one of the buttons and have ALL of the buttons change color, you're going to have to provide the other buttons to each button's constructor, and then have changeColor call setBackground on each of the other buttons. — Nate W.
– Nate W., Commented Feb 8, 2011 at 21:10
@shakedown: When you say "you're going to have to provide the other buttons to each button's constructor", what do you mean by this ? How would I go about doing this ? Thank you very much for your help — user476033
– user476033, Commented Feb 8, 2011 at 21:15
@user476033: You need a way to reference the other buttons from inside your ButtonJava. One way of doing this is to have your ButtonJava constructor take a list of JButton (or ButtonJava), and then in changeColor you would iterate over that list of buttons and call setBackground on each one. — Nate W.
– Nate W., Commented Feb 8, 2011 at 21:34

Nate W. · Accepted Answer · 2011-02-08 20:43:56Z

1

Simple mistake - you're not creating your custom button class, you're using JButton.
Change the following line:
buttons[i] = new JButton("Pick Me");
To:
buttons[i] = new ButtonJava();

answered Feb 8, 2011 at 20:43

Nate W.

9,2776 gold badges46 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ColinD · Accepted Answer · 2011-02-08 20:44:02Z

0

In main, you're making normal JButtons and adding them to your UI when I guess you mean to be adding ButtonJava instead.

answered Feb 8, 2011 at 20:44

ColinD

110k30 gold badges205 silver badges205 bronze badges

Comments

POSIX_ME_HARDER · Accepted Answer · 2011-02-08 21:01:04Z

0

Shouldn't it be :

ButtonJava buttons[] = new ButtonJava[3];
for(int i = 0;i<buttons.length ; i++){
    buttons[i] = new ButtonJava(); 
    panel.add(buttons[i]);
 }

?

answered Feb 8, 2011 at 21:01

POSIX_ME_HARDER

7629 silver badges22 bronze badges

Collectives™ on Stack Overflow

Java GUI is being created, but event is not triggering anything

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related