Passing a parameter through URL via loop

Question

So, I'm trying to pass the name of the PDF to the URL so that the view can display the relevant PDF.

urls.py

path('show-invoice/<str:invoice>', views.pdf_view, name ="pdfview")

views.py

def pdf_view(request, invoice):
    invoicename = Laptop.objects.get(invoice=invoice)
    invoicename = invoicename.invoice
    pdfpath = settings.MEDIA_ROOT + invoicename
    pdfpath = pdfpath.replace('/', '\\')
    try:
       return FileResponse(open(pdfpath, 'rb'), content_type='application/pdf')
    except FileNotFoundError:
       raise Http404()

models.py

invoice = models.FileField(default='default.pdf', upload_to='uploads/')

invoice_list.html

<h2>View invoices</h2>
{%for i in invoices%}
<ul>
   <li>
       <a href = "{%url 'laptops:pdfview' invoice=i.invoice%}"> {{i.invoice}} </a>
   </li>
</ul>
{%endfor%}

Now, my question is: Why does it work when I use invoice='default.pdf' and not when I useinvoice=i.invoice? I get the following error

NoReverseMatch at /invoices/
Reverse for 'pdfview' with keyword arguments '{'invoice': 'uploads/default1.pdf'}' not found. 1 pattern(s) tried: ['show\\-invoice\\/(?P<invoice>[^/]+)$']

Daniel Roseman · Accepted Answer · 2018-03-24 19:29:30Z

2

Because the str converter you have used in the path does not match the \ in your invoice attribute.

You can use the path converter instead:

path('show-invoice/<path:invoice>', ...)

edited Mar 24, 2018 at 19:29

answered Mar 24, 2018 at 19:19

Daniel Roseman

602k68 gold badges910 silver badges923 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Reez0 Over a year ago

Wow. Never would have picked up on that. Thanks, Daniel!

Collectives™ on Stack Overflow

Passing a parameter through URL via loop

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related