Use methods inside Parallel.ForEach loop

Question

I should use Parallel.ForEach loop, and inside there should be call to method.

Parallel.ForEach(myList, item => {  
   DoSomethingWithItem(item);
 }
);

Should that method be Task or whatever?

private Task DoSomethingWithItem(MyClass item);

Also, this method shouldn't have return type, but I have warning "not all code paths return a value". Tried to put void keyword but seems it doesn't go in same context with Task keyword.

Community · Accepted Answer · 2020-06-20 09:12:55Z

3

No

Do not make it more complicated than it has to be.

Parallel.ForEach(myList, item => {  
   DoSomethingWithItem(item);
 }
);

is perfectly fine for void DoSomethingWithItem(MyClass item).

Making it "more" async is overkill at best, counterproductive in the worst case.

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Mar 27, 2018 at 12:23

nvoigt

77.8k28 gold badges103 silver badges156 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user3681549 Over a year ago

Would it be problem if DoSomethingWithItem has few tasks that should perform?

public void DoSomethingWithItem(MyClass item) {    var tasks = new Task[3];    task[0] = DoSomething1(item);    task[1] = DoSomething2(item);    task[2] = DoSomething3(item); }

nvoigt Over a year ago

The syntax of running multiple tasks in parallel is not correct, but generally speaking, yes, if your method wants to start multiple tasks and wait for all, that's fine.

Collectives™ on Stack Overflow

Use methods inside Parallel.ForEach loop

1 Answer 1

No

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

No

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related