How to pass php variable in window.location javascript

Question

I want to pass the php variable inside the window.location javascript this is my php code and i am unable to do that.

echo '<script>location.href = "reportConsumption.php?creategenReport="'.$genid.'"&sDate="'.$startdate.'"&eDate="'.$enddate;</script>';

header is not working it is not redirecting so i am using location.href — hotshot code
– hotshot code, Commented Mar 31, 2018 at 12:18
If header("Location: $url") is not working then i am sure location.href will not work also. BTW try once:- echo '<script>location.href ="reportConsumption.php?creategenReport='.$genid.'&sDate='.$startdate.'&eDate='.$enddate.'"</script>'; — Death-is-the-real-truth
– Death-is-the-real-truth, Commented Mar 31, 2018 at 12:20

eborrallo · Accepted Answer · 2018-03-31 12:21:35Z

2

try to set quotation marks

echo '<script>location.href = "reportConsumption.php?creategenReport='.$genid.'&sDate='.$startdate.'&eDate='.$enddate.'"</script>';

answered Mar 31, 2018 at 12:21

eborrallo

7601 gold badge8 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ArtisticPhoenix · Accepted Answer · 2018-04-01 02:49:41Z

1

You are closing your quote in JS

echo '<script>location.href = "reportConsumption.php?creategenReport="'.$genid.'"&sDate="'.$startdate.'"&eDate="'.$enddate;</script>';

Should be

 echo '<script>location.href = "reportConsumption.php?creategenReport='.$genid.'&sDate='.$startdate.'&eDate='.$enddate.'</script>';

This will cause an error in JS on the client side, you could see this by pressing f12 and looking in the console log in the browser debugger. Your source code will look like this

 <script>location.href = "reportConsumption.php?creategenReport="35"&sDate="...

 //where this is a quoted block
 "reportConsumption.php?creategenReport="
 //and this is just chilling in space
 35
 //and then a new quoted block, etc.
 "&sDate="

And you had this other (php syntax error) issue I took the liberty of fixing.

 .$enddate;</script>';

Just in PHP you can redirect with

  header("Location: $url");

But you have to be sure of 2 things:

You do not output "Anything" not even a line return before calling header
You call exit(); immediately after it. If you don't PHP will continue to execute the current script after it executes the redirect. Which is probably not desirable.

edited Apr 1, 2018 at 2:49

answered Mar 31, 2018 at 12:20

ArtisticPhoenix

21.7k2 gold badges27 silver badges38 bronze badges

6 Comments

hotshot code Over a year ago

lets suppose i have this kind of situation then? echo '<script>window.open("reportConsumption.php?creategenReport='.$genid.'&sDate='.$startdate.'&eDate='.$enddate.'",'_blank');</script>';

ArtisticPhoenix Over a year ago

Then you should probably double quote this '_blank' like "_blank", basically this is the opposite issue where $enddate.'",'_blank specifically .'",' closes the block. PS you can do inline code format with the backtic ` its aka ~ tilde

hotshot code Over a year ago

man it really worked but the problem is that it is showing popup blocked can i resolve it via code

ArtisticPhoenix Over a year ago

I would post it as a separate question. Comments is not really the place to handle it, just saying.

hotshot code Over a year ago

i am not been able to post question before 60 mins

|

Syscall · Accepted Answer · 2018-03-31 12:21:39Z

1

You are closing the double quotes too early. It should be close at the end of the URL. So you have a syntax error in your JavaScript:

echo '<script>location.href = "reportConsumption.php?creategenReport='.$genid.'&sDate='.$startdate.'&eDate='.$enddate.'";</script>';

Or separate using a variable to be more clear:

$url = 'reportConsumption.php?creategenReport='.$genid.'&sDate='.$startdate.'&eDate='.$enddate;
echo '<script>location.href = "'.$url.'";</script>';

edited Mar 31, 2018 at 12:21

answered Mar 31, 2018 at 12:19

Syscall

19.8k10 gold badges44 silver badges60 bronze badges

Comments

ScaisEdge · Accepted Answer · 2018-03-31 12:21:35Z

0

You should not use double quote around the values for GET param

  echo '<script>location.href = "reportConsumption.php?creategenReport='.$genid. 
          '&sDate='.$startdate.'&eDate='. $enddate .'"';</script>';

answered Mar 31, 2018 at 12:21

ScaisEdge

134k10 gold badges98 silver badges111 bronze badges

Collectives™ on Stack Overflow

How to pass php variable in window.location javascript

4 Answers 4

Comments

6 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related