how to manipulate string.format with if else in c# asp.net?

Question

i have a string in which i am using String.format in this i want to remove the 2nd parameter if string iteration will come as ="" or NULL and also want to remove the
. AND [Source].[System.IterationPath] IN ('{1}') from the String that will be formed.

    public void GetProjectInfo(string projectname,string Iteration)
            {
    string querystring = string.Format("select [System.Id], [System.Title],[Story.Author],[Story.Owner],[System.AssignedTo]," +
" [System.WorkItemType],[Microsoft.VSTS.Scheduling.StoryPoints],[Microsoft.VSTS.Common.Priority]," +
"[Microsoft.VSTS.Scheduling.Effort], [Actual.Effort.Completed]" +
",[System.State]," +
 "[System.IterationPath]" +
 " FROM WorkItemLinks" +
 " WHERE" +
" ([Source].[System.TeamProject]='{0}'" +
 " and [Source].[System.WorkitemType] IN ('Feature', 'Bug', 'Product Backlog Item', 'Task')" +
    " AND [Source].[System.IterationPath] IN ('{1}'))"//this line of code will be removed along with iteration parameter 
    +
    " and ([System.Links.LinkType]='System.LinkTypes.Hierarchy-Forward')" +
    " ORDER BY [System.Id] " +
    " mode (Recursive)", projectname, Iteration);

    }

Do you know that you could remove all that messy + and "" just prepending the @ character in front to the opening quote of the string? — Steve
– Steve, Commented Apr 1, 2018 at 9:44

tchelidze · Accepted Answer · 2018-04-01 09:49:30Z

Try

public void GetProjectInfo(string projectname, string Iteration)
{
    var query =
            $@"SELECT 
                 [System.Id], [System.Title],[Story.Author],[Story.Owner],[System.AssignedTo],
                 [System.WorkItemType],[Microsoft.VSTS.Scheduling.StoryPoints],[Microsoft.VSTS.Common.Priority],
                 [Microsoft.VSTS.Scheduling.Effort], [Actual.Effort.Completed], [System.State], [System.IterationPath] 
             FROM WorkItemLinks 
             WHERE ([Source].[System.TeamProject]='{projectname}' 
                   AND [Source].[System.WorkitemType] IN ('Feature', 'Bug', 'Product Backlog Item', 'Task') 
                   ${(string.IsNullOrEmpty(Iteration) ? "" : $"AND [Source].[System.IterationPath] IN ('{Iteration}'))") }
                   AND ([System.Links.LinkType]='System.LinkTypes.Hierarchy-Forward')
            ORDER BY [System.Id] mode (Recursive)";
}

Note

string concatenation is a bad practice for building a SQL Query, there is a thread of SQL Injection

Collectives™ on Stack Overflow

how to manipulate string.format with if else in c# asp.net?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related