regex for all urls in string not capturing urls with question mark

Question

I start with this PHP string.

$bodyString = '
    another 1 body
    reg http://www.regularurl.com/home
    secure https://facebook.com/anothergreat.
    a subdomain http://info.craig.org/
    dynamic; http://www.spring1.com/link.asp?id=100408
    www domain; at www.wideweb.com
    single no subdomain; simple.com';

Need to turn all domains, urls into anchor(<a>) elements.

preg_replace('#[-a-zA-Z0-9@:%_\+.~\#?&//=]{2,256}\.[a-z]{2,4}\b(\/[-a-zA-Z0-9@:%_\+.~\#?&//=]*)?#si', '<a href="$0">$0</a>', $bodyString)

$bodyString result:

'another 1 body
    reg <ahref="http://www.regularurl.com/home">http://www.regularurl.com/home</a>
    secure <a href="https://facebook.com/anothergreat.">https://facebook.com/anothergreat.</a>
    a subdomain <a href="http://info.craig.org/">http://info.craig.org/</a>
    dynamic; <a href="http://www.spring1.com/link.asp">http://www.spring1.com/link.asp</a>?id=100408
    www domain; at <a href="www.wideweb.com">www.wideweb.com</a>
    single no subdomain; <a href="simple.com">simple.com</a>';

Result: All urls, domains are turned into <a> except http://www.spring1.com/link.asp?id=100408

What is missing in the regex to make this work?

I think if you can write this much regex as in the question, you can find the solution yourself. Before copy pasting code from internet, please make sure to try it from your end and post your research as well. — Ashish Choudhary
– Ashish Choudhary, Commented Apr 3, 2018 at 13:47

Noman · Accepted Answer · 2018-04-03 13:42:57Z

1

$bodyString = '
    another 1 body
    reg http://www.regularurl.com/home
    secure https://facebook.com/anothergreat.
    a subdomain http://info.craig.org/
    dynamic; http://www.spring1.com/link.asp?id=100408
    www domain; at www.wideweb.com
    single no subdomain; simple.com';

$regex = '@(http)?(s)?(://)?(([a-zA-Z])([-\w]+\.)+([^\s\.]+[^\s]*)+[^,.\s])@'; 
$converted_string = preg_replace($regex, '<a href="$0">$0</a>', $bodyString);
echo $converted_string;

Demo

Regex Explanation here

answered Apr 3, 2018 at 13:42

Noman

4,1361 gold badge23 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2020-06-20 09:12:55Z

1

Building on @WiktorStribiżew's comment, you could try this:

[^\s]{2,256}\.[a-z]{2,4}\b(?:[?/][^\s]*)*

Trial over here

Note - Although there are already 2 answers as of now, this seems to be more concise, using [^\s]

Explanation -

[^\s]{2,256} matches 2 to 256 characters which is the https://facebook and https://www.randomdomain part,
\. matches the dot after that,
[a-z]{2,4} is the domain extension eg: com, in etc.
\b is the word boundary,
(?:[?/][^\s]*)* is a non-capturing group which matches either a slash / or question mark ? and more of the url, all of which can be repeated zero-or-more times, indicating the sub-pages of the URL.

To gain a better understanding of Regex Syntax, you should try this website: rexegg.com

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Apr 3, 2018 at 13:47

Robo Mop

3,5611 gold badge12 silver badges23 bronze badges

Comments

Ashish Choudhary · Accepted Answer · 2018-04-03 13:45:58Z

0

[-\w@:%+.\~#?&/=]{2,256}\.[a-z]{2,4}\b[^\s]*

[^\s]* will add any non-space character to the url. When there's a space its not a part of the URL. Simple and easy.

working url here

answered Apr 3, 2018 at 13:45

Ashish Choudhary

2,0341 gold badge20 silver badges26 bronze badges

Collectives™ on Stack Overflow

regex for all urls in string not capturing urls with question mark

3 Answers 3

Comments

Explanation -

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Explanation -

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related