13

getUser is an async function? if it is going to take longer time to resolve? is it going to always return the right value in my someotherclass.

class IdpServer {
    constructor() {
        this._settings = {
            // some identity server settings.
        };
        this.userManager = new UserManager(this._settings);
        this.getUser();
    }

    async getUser() {
        this.user = await this.userManager.getUser();
    }

    isLoggedIn() {
        return this.user != null && !this.user.expired;
    }
}

let idpServer = new IdpServer();
export default idpServer;


// another class 
// import IdpServer from '...'
 class SomeOtherClass {
     constructor() {
        console.log(IdpServer.isLoggedIn());
     }
 }
Improve this question
9
  • 5
    Constructors should generally be used to get an object into a usable, valid state. Not to do lots of work. Commented Apr 6, 2018 at 14:12
  • 1
    @JamesThorpe Adding on that, a constructor builds an object, it doesn't promise to build part of an object Commented Apr 6, 2018 at 14:13
  • I think you're going to have to make the client code await the call to getUser() before checking the status. Commented Apr 6, 2018 at 14:13
  • What does getUser do actually? Commented Apr 6, 2018 at 14:15
  • 2
    Duplicates : stackoverflow.com/questions/39028882/…, stackoverflow.com/questions/37351146/…, stackoverflow.com/questions/24398699/… Commented Apr 6, 2018 at 14:19

1 Answer 1

Reset to default
17

This is a problem that is related to this popular question.

Once a code is asynchronous, it cannot be used in synchronous manner. If the use of raw promises is unwanted, all control flow should be performed with async functions.

The problem here is that getUser provides a promise of user data, not user data itself. A promise is lost in constructor, and this is antipattern.

One way to solve the problem is to provide initialization promise for IdpServer, while the rest of API will be synchronous:

class IdpServer {
    constructor() {
        ...
        this.initializationPromise = this.getUser(); 
    }

    async getUser() {
        this.user = await this.userManager.getUser();
    }

    isLoggedIn() {
        return this.user != null && !this.user.expired;
    }
}

// inside async function
await idpServer.initializationPromise;
idpServer.isLoggedIn();

Depending on how the application works, IdpServer.initializationPromise can be handled on application initialization to guarantee that all units that depend on IdpServer won't be initialized until it's ready.

Another way is to make IdpServer entirely asynchronous:

class IdpServer {
    constructor() {
        ...
        this.user = this.getUser(); // a promise of user data
    }

    async getUser() {
        return this.userManager.getUser();
    }

    async isLoggedIn() {
        const user = await this.user;
        return user != null && !user.expired;
    }
}

// inside async function
await idpServer.isLoggedIn();

It's expected that all units that depend on it will also have asynchronous API.

Improve this answer
Sign up to request clarification or add additional context in comments.

4 Comments

This is new implementation, @estus this is being int a function, which was being used in 20 places at least in the application. Just thinking if there is an easier way so that it require minimal changes.
Since this was design mistake, this should be refactored. If a promise exists, there should be a way to chain it in places that depend on the results of this promise. I guess the first way requires less changes and is generally more common.
Just want to let you guys know, I fixed it by making this as the first thing to run and only when this resolves, then router will render the page template.
@hashbytes - how can you test for when the promise resolves?

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.