Nested IF statement PHP

Question

after a bit of adivce -I have a rather lengthy chunk of nested if statement, and I'm looking at ways I can refine it and make it more efficient. I did think of a switch - but I can't see how I could split this up.

Any thoughts appreciated

  $portfolioItems [$i] = array(//assign vars into array
  'imagePath' => '/sites/jda_redev/'.$myrow_home->path.'/thumbs/thumbs_'.$myrow_home->filename,
  'altText' => $myrow_home->alttext,
  'description' => $myrow_home->description,
  'client' => $extra_client->field_value,
  'job' => $extra_job->field_value,
  'channel' => $extra_channel->field_value,
  'channeltwo' => $extra_channeltwo->field_value,
  'channelthree' => $extra_channelthree->field_value,
  'channelfour' => $extra_channelfour->field_value,
  'channelfive' => $extra_channelfive->field_value,
  'sector' => $extra_sector->field_value,
  'workerone' => $extra_workerone->field_value,
  'workertwo' => $extra_workertwo->field_value,
  'gallery' => $galleryName,
  'mediaType' => $media_type->field_value,
  'videoName' => $video_name->field_value
  );

if ( $portfolioItems [$i]['imagePath'] == "" )
      {$portfolioItems [$i]['imagePath'] = " ";}
      if ( $portfolioItems [$i]['altText'] == "" )
      {$portfolioItems [$i]['altText'] = " ";}
      if ( $portfolioItems [$i]['description'] == "" )
      {$portfolioItems [$i]['description'] = " ";}
      if ( $portfolioItems [$i]['client'] == "" )
      {$portfolioItems [$i]['client'] = " ";}
      if ( $portfolioItems [$i]['job'] == "" )
      {$portfolioItems [$i]['job'] = " ";}
      if ( $portfolioItems [$i]['channel'] == "" )
      {$portfolioItems [$i]['channel'] = " ";}
      if ( $portfolioItems [$i]['channeltwo'] == "" )
      {$portfolioItems [$i]['channeltwo'] = " ";}
      if ( $portfolioItems [$i]['channelthree'] == "" )
      {$portfolioItems [$i]['channelthree'] = " ";}
      if ( $portfolioItems [$i]['channelfour'] == "" )
      {$portfolioItems [$i]['channelfour'] = " ";}
      if ( $portfolioItems [$i]['channelfive'] == "" )
      {$portfolioItems [$i]['channelfive'] = " ";}
      if ( $portfolioItems [$i]['sector'] == "" )
      {$portfolioItems [$i]['sector'] = " ";}
      if ( $portfolioItems [$i]['workerone'] == "" )
      {$portfolioItems [$i]['workerone'] = " ";}
      if ( $portfolioItems [$i]['workertwo'] == "" )
      {$portfolioItems [$i]['workertwo'] = " ";}
      if ( $portfolioItems [$i]['gallery'] == "" )
      {$portfolioItems [$i]['gallery'] = " ";}
      if ( $portfolioItems [$i]['mediaType'] == "" )
      {$portfolioItems [$i]['mediaType'] = " ";}
      if ( $portfolioItems [$i]['videoName'] == "" )
      {$portfolioItems [$i]['videoName'] = " ";}

do you have more items in $portfolioItems [$i] not listed here? or are you wanting to do this for the whole array? — David Houde
– David Houde, Commented Feb 11, 2011 at 15:49
why don't you add values('mediaType','videoName') to an array and loop the if statement using the for loop? — reggie
– reggie, Commented Feb 11, 2011 at 15:50
are there more options in the portfolioItem[$i]['more options here']? or are you checking all the options individually? — Phill Pafford
– Phill Pafford, Commented Feb 11, 2011 at 15:51
I feel sorry for your fingers that you ever typed something like this out! — Dan Grossman
– Dan Grossman, Commented Feb 11, 2011 at 15:53

Dan Grossman · Accepted Answer · 2011-02-11 15:50:38Z

8

foreach ($portfolioItems[$i] as $key => $val) {
  if ($val == "") {
    $portfolioItems[$i][$key] = " ";
  }
}

answered Feb 11, 2011 at 15:50

Dan Grossman

52.5k10 gold badges115 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

frazzle Over a year ago

thanks - this does the trick. Good to chop my bloated code down !

Joel Etherton · Accepted Answer · 2011-02-11 15:50:13Z

5

You could use a foreach iteration to accomplish it:

foreach ($portfolioItems[$i] as &$value) {
    if($value == "") $value = " ";
}

// Thanks @Mark Baker, I forgot this very important line:
unset($value);

answered Feb 11, 2011 at 15:50

Joel Etherton

37.5k10 gold badges92 silver badges106 bronze badges

2 Comments

Mark Baker Over a year ago

Just for safety, unset($value); after the loop

Joel Etherton Over a year ago

@Mark Baker - file that one under the "duh" category. Thanks.

Dolbz · Accepted Answer · 2011-02-11 15:49:51Z

1

How about this?

$portfolioKeys = Array('sector', 'workerone'); // Add all keys to check in here

foreach($portfolioKeys as $key) {
    if ($portfolioItems[$i][$key]) == "") {
       $portfolioItems[$i][$key] = "";
    }
}

answered Feb 11, 2011 at 15:49

Dolbz

2,1061 gold badge16 silver badges26 bronze badges

2 Comments

Joel Etherton Over a year ago

Don't you need the & to perform the modification? php.net/manual/en/control-structures.foreach.php

Joel Etherton Over a year ago

@Dan Grossman - Ah, yes, I see. Caffeine levels are hovering around empty at the moment. I glossed right over that little tidbit in this code. Thanks.

Raffael · Accepted Answer · 2011-02-11 15:50:05Z

1

how about foreach-looping through your array?

answered Feb 11, 2011 at 15:50

Raffael

20.1k16 gold badges93 silver badges169 bronze badges

Comments

CrayonViolent · Accepted Answer · 2011-02-11 15:52:02Z

0

I don't see a nested condition but anyways, it looks like you can (maybe - if those are ALL your elements) do:

foreach ($portfolioItems[$i] as $k => $v) {
  $portfolioItems[$i][$k] = ($v == "")? " " : $v;
}

answered Feb 11, 2011 at 15:52

CrayonViolent

32.6k6 gold badges61 silver badges80 bronze badges

Collectives™ on Stack Overflow

Nested IF statement PHP

5 Answers 5

1 Comment

2 Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

2 Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related