How to insert data into MySQL table using Node and express?

Question

I am using Node with express and MySQL for database. I have created an ejs file wherein I have a form (method=POST)

In my server file, I can retrieve the data send by that form, I can even console.log it and get the desired output. Since there are multiple entries in the form, I am using different variables to store those entries in my server file.

In the query, when I am passing those variables to insert into the database, the database only inserts Null, instead of the actual data stored in the variable.

The code for the form is given below:

    <form action="/newuser" style="border:1px solid #ccc" method="post">
  <div class="container">
    <h1>Sign Up</h1>
    <p>Please fill in this form to create an account.</p>
    <hr>

    <label for="Name"><b>Name</b></label>
    <input type="text" placeholder="Enter Name" name="name" required>

    <label for="email"><b>Email</b></label>
    <input type="text" placeholder="Enter Email" name="email" required>


    <label for="psw"><b>Password</b></label>
    <input type="password" placeholder="Enter Password" name="psw" required>

    <hr>

    <label for="address"><b>Address</b></label>
    <input type="text" placeholder="House no and Street" name="address" required>


    <label for="city"><b>City</b></label>
    <input type="text" placeholder="Enter City" name="city" required>

    <label for="pin"><b>Postal Code</b></label>
    <input type="number" placeholder="Enter pin" name="pin" required>

    <label for="country"><b>Country</b></label>
    <input type="text" placeholder="Enter Country" name="country" required>

    <label for="mobile"><b>Mobile Number</b></label>
    <input type="number" placeholder="Enter Mobile Number" name="mobile" required>




    <div class="clearfix">

     <a href="/"><button type="button" class="cancelbtn">Cancel</button></a>
      <button type="submit" class="signupbtn">Sign Up</button>
    </div>
  </div>
</form>

The code on the server file is given below:

 var express = require("express");
var bodyParser = require("body-parser");
var app = express();
var mysql = require('mysql');

app.use( express.static( "public" ) );
app.use( bodyParser.json() );       // to support JSON-encoded bodies
app.use(bodyParser.urlencoded({     // to support URL-encoded bodies
  extended: true
})); 


var connection = mysql.createConnection({
    host: "localhost",
    user:"root",
    password:"",
    database:"bakery"
});


//some more code to get different routes

connection.connect(function(error){
    if(error){
        console.log("Error while connecting to database")
    }
    else{

        // console.log("connected");
 connection.query("SELECT * FROM products", function (err, result, fields) {
    if (err) throw err;
        for (var i = 0; i < result.length; i++) {
       var row = result[i];
       console.log(row.ProductName, "costs", row.Price, "and its from category", row.Category  );
}   
    // console.log(result);
    })
}});


app.use(bodyParser.urlencoded({ extended: true }));
app.set("view engine", "ejs");

app.post("/newuser", function(req, res) {
    // get data from forms and add to the table called user..

    var name = req.body.name;
    var email = req.body.email;
    var password = req.body.psw;
    var city = req.body.city;
    var address = req.body.address;
    var country= req.body.country
    var pin = req.body.pin;
    var mobile = req.body.mobile;

    console.log(name, mobile, pin);

    connection.query("INSERT INTO user (Name, Email, Address, City, Country, password) VALUES", (name , email, address, city, country , password), function (err, result) {
    if (err) throw err;
    console.log("1 record inserted");
  });
    res.redirect("/");

Using this code, it only inserts Null into the database no matter what I type in the form.

Yes I did, and it showed me the data perfectly fine in the log. — Mursil
– Mursil, Commented Apr 13, 2018 at 18:55

Zeeshan Hassan Memon · Accepted Answer · 2018-04-13 17:12:30Z

9

Try like this:

var sql = `INSERT INTO user 
            (
                Name, Email, Address, City, Country, password
            )
            VALUES
            (
                ?, ?, ?, ?, ?, ?
            )`;
connection.query(sql, [name , email, address, city, country , password], function (err, data) {
    if (err) {
        // some error occured
    } else {
        // successfully inserted into db
    }
});

answered Apr 13, 2018 at 17:12

Zeeshan Hassan Memon

8,3654 gold badges47 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mursil Over a year ago

Thank you so much! It worked perfectly fine. Can you please explain why the code that I had written was not working?

Zeeshan Hassan Memon Over a year ago

great it worked for you :) I think there is problem in syntax, you can continue with the style I have showed you it is easy and understandable.

tMan44wiz · Accepted Answer · 2023-03-31 16:30:49Z

1

I think the issue is from your Query syntax. I restructured your code to the one below. I hope it will solve the problem.

app.post("/newuser", function(req, res) {
    // get data from forms and add to the table called user..

    var reqBody = req.body;

    const name = reqBody.name;
    const email = reqBody.email;
    const password = reqBody.psw;
    const city = reqBody.city;
    const address = reqBody.address;
    const country= reqBody.country
    const pin = reqBody.pin;
    const mobile = reqBody.mobile;

    const queryString = `INSERT INTO user (Name, Email, Address, City, Country, password) VALUES ('"+name+"', '"+email+"', '"+address+"', '"+city+"', '"+country+"', '"+password+"')`;

    connection.query(queryString, function (err, result) {
    if (err) {
        // Throw your error output here.
        console.log("An error occurred.");
    } else {
        // Throw a success message here.
        console.log("1 record successfully inserted into db");
    }
  });

edited Mar 31, 2023 at 16:30

answered Apr 14, 2020 at 18:37

tMan44wiz

1461 silver badge5 bronze badges

1 Comment

user11461061 Over a year ago

This post has helped me out! Thank you alot

Joe Powell · Accepted Answer · 2021-10-12 18:52:18Z

0

    let name = req.body.name;
    let email = req.body.email;
    let password = req.body.psw;

     const sql = `INSERT INTO user (name, email, password)
       VALUES ('${name}','${email}', '${password}')`;
         db.query(sql, (err, res)=> {
         if(err) throw err;
      })

edited Oct 12, 2021 at 18:52

answered Oct 12, 2021 at 18:47

Joe Powell

12 bronze badges

Collectives™ on Stack Overflow

How to insert data into MySQL table using Node and express?

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related