Need help in login validation using javascript

Question

Please could somebody point me out what is the error here? Using javascript i am validating the user input. When i click the login button without checking the javascript function, it goes to the welcome page. Here is my code:

<script type="text/javascript">  
function validLogin()
{
        if(document.getElementById("txtUserName").value == "")
        {
          alert("Please enter your UserName");
          return false;
        }

        if(document.getElementById("txtPassword").value == "")
        {
          alert("Please enter your Password");
          return false;
        }

}
</script>


 protected void Page_Load(object sender, EventArgs e)
 {
     BtnLogin.Attributes.Add("onClick","return ValidLogin();");     
 }

How does the HTML code look that this produces? Server side code is not very relevant for a client side issue... — Tomalak
– Tomalak, Commented Jan 31, 2009 at 9:20

Christian C. Salvadó · Accepted Answer · 2009-01-31 05:47:12Z

1

I see that you're using ASP .NET (the Page_Load event on your posted code).

I think that will be easier to handle validation through ASP .NET Validation Controls, i.e. RequiredFieldValidator.

answered Jan 31, 2009 at 5:47

Christian C. Salvadó

831k185 gold badges929 silver badges845 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

geowa4 · Accepted Answer · 2009-01-31 05:58:03Z

1

Check your case on return ValidLogin(); it doesn't match.

P.S.: I hope you aren't performing all user validation client-side.

answered Jan 31, 2009 at 5:58

geowa4

42.1k17 gold badges90 silver badges107 bronze badges

Comments

Phaedrus · Accepted Answer · 2009-01-31 05:59:12Z

0

It would probably be easier to user ASP .NET validation controls, here's a sample:

User Name:
<asp:TextBox ID="UserName" runat="server" />
<asp:RequiredFieldValidator 
    ID="UserNameValidator" 
    ControlToValidate="UserName"
    ErrorMessage="User Name Required" 
    runat="server" />
Password:
<asp:TextBox ID="Password" runat="server" />
<asp:RequiredFieldValidator 
    ID="PasswordValidator" 
    ControlToValidate="Password"
    ErrorMessage="Password Required"
    runat="server" />

answered Jan 31, 2009 at 5:59

Phaedrus

8,43128 silver badges28 bronze badges

Comments

Omer Bokhari · Accepted Answer · 2009-01-31 06:05:17Z

0

first make sure it's not a difference in case... your javascript function is validLogin and in Page_Load you have ValidLogin

answered Jan 31, 2009 at 6:05

Omer Bokhari

60k12 gold badges46 silver badges60 bronze badges

Collectives™ on Stack Overflow

Need help in login validation using javascript

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related