PHP fputcsv outputting double records

Question

I'm using this fputcsv code:

$result = mysql_query('SELECT * FROM `mash`');
if (!$result) die('Couldn\'t fetch records');
$fp = fopen('testCSV.csv', 'w');
if ($fp && $result) {
    while ($row = mysql_fetch_array($result)) {
        fputcsv($fp, array_values($row));
    }
    die;
}
fclose($fp);

It outputs the CSV great but there are two columns for each mysql column (so everything is doubled)

could anyone see why that would be?

If the query fails, you die, which ends the program, so there's no point in checking $result later on when it can't possibly be false. You also die after your loop ending the program before you close the file pointer. Why? — Dan Grossman
– Dan Grossman, Commented Feb 14, 2011 at 15:40

Brian · Accepted Answer · 2011-02-14 15:36:38Z

7

try this:

$result = mysql_query('SELECT * FROM `mash`');
if (!$result) die('Couldn\'t fetch records');
$fp = fopen('testCSV.csv', 'w');
if ($fp && $result) {
    while ($row = mysql_fetch_array($result,MYSQL_ASSOC)) {
        fputcsv($fp, array_values($row));
    }
    die;
}
fclose($fp);

mysql_fetch_array will return a combined array by default, this will return associative array only. Or use MYSQL_NUM for numbered - http://php.net/manual/en/function.mysql-fetch-array.php

answered Feb 14, 2011 at 15:36

Brian

8,6212 gold badges27 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

JeremyCanfield Over a year ago

thank you very much for this answer. I was experiencing the issue described in this post, and your answer perfectly fixed the issue I was facing. Thank you!

blongden · Accepted Answer · 2011-02-14 15:35:44Z

1

http://php.net/manual/en/function.mysql-fetch-array.php

The second parameter to mysql_fetch_array is the key here. The default is to fetch BOTH the assoc ant int key. You probably want to pass in MYSQL_ASSOC here.

answered Feb 14, 2011 at 15:35

blongden

111 bronze badge

Comments

Aron Rotteveel · Accepted Answer · 2011-02-14 15:35:15Z

0

mysql_fetch_array() returns both a numeric and associative index by default:

Quoting the manual (emphasis mine):

Returns an array of strings that corresponds to the fetched row, or FALSE if there are no more rows. The type of returned array depends on how result_type is defined. By using MYSQL_BOTH (default), you'll get an array with both associative and number indices. Using MYSQL_ASSOC, you only get associative indices (as mysql_fetch_assoc() works), using MYSQL_NUM, you only get number indices (as mysql_fetch_row() works).

Solution:

Use mysql_fetch_assoc()
Or: mysql_fetch_array($result, MYSQL_ASSOC)

answered Feb 14, 2011 at 15:35

Aron Rotteveel

83.4k17 gold badges106 silver badges129 bronze badges

Collectives™ on Stack Overflow

PHP fputcsv outputting double records

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related