python sql TypeError: 'str' object is not callable

Question

using SQL trying to delete a client from a table that is input through a tkinter listbox and I'm getting this error:

TypeError: 'str' object is not callable`

this is the code i'm working with:

class delete_client:
def __init__(self):
    self.window = Tk()
    self.window.wm_protocol("WM_DELETE_WINDOW", self.close)
    self.window.title("Delete Clients")

    self.delete_client_lst = Listbox(self.window, width=50, height=15)
    self.delete_client_lst.grid(row=0, column=0, sticky=W, columnspan=2, padx=10, pady=3)
    self.delete_button = Button(self.window, text='Delete Client', command = self.delete)
    self.delete_button.grid(row=4,column = 2,sticky =E)

    self.surname_lbl = Label(self.window, text='Client Surname')
    self.surname_lbl.grid(row=2, column=0)

    self.surname_entry = Entry(self.window, width=10)
    self.surname_entry.grid(row=2, column=1)


def delete(self):
    given_surname = self.surname_entry.get()

    sql = "DELETE FROM Client"
    sql = "WHERE Surname = %s" (given_surname)
    c.execute(sql)

def close(self):
    self.window.destroy()

thanks

Cory Kramer · Accepted Answer · 2018-04-26 15:43:50Z

2

This line

sql = "WHERE Surname = %s" (given_surname)

should be

sql = "WHERE Surname = %s" % given_surname

or

sql = "WHERE Surname = {}".format(given_surname)

Otherwise it looks like you are trying to call a function off your string object where given_surname is being passed as a function argument.

edited Apr 26, 2018 at 15:43

answered Apr 26, 2018 at 15:42

Cory Kramer

119k19 gold badges176 silver badges233 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

roganjosh Over a year ago

That will use string interpolation, so at major risk of injection attacks. Also, the first part of the query will be lost. Just use c.execute("DELETE FROM Client WHERE Surname = ?", (given_surname,)). This will escape malicious input and will also be faster.

user3483203 Over a year ago

Really should not be using string operations here.

Chubby_Goujon Over a year ago

so, i used: 'c.execute("DELETE FROM Client WHERE Surname = ?", (given_surname,))' and i'm getting no more errors, but it only seems to be temporarily removing the data from the table. when i close and re-run the program they haven't been deleted...

roganjosh Over a year ago

Because you need conn.commit() to push the changes.

Collectives™ on Stack Overflow

python sql TypeError: 'str' object is not callable

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related