Run code after query in AngularJS

Question

I have created a small project, but I have some problems. I want to run some JavaScript code after my query. My code is like this:

Book.get({
    id: $stateParams.id,
    min: 0,
    max: 3
}).$promise.then(function(data){
    vm.list=data;
}).finally(function () {

});
vm.top=vm.list.name;

vm.top is undefined, because the query has not returned yet.

keep everything within a promise; since it's an asynchronous callback, it can return after few milliseconds or minutes - you can't assign a variable after it. vm.top is undefined because it runs before your callback — Aleksey Solovey
– Aleksey Solovey, Commented Apr 27, 2018 at 8:11

Peter Mortensen · Accepted Answer · 2018-04-27 12:40:14Z

2

This is not how you should deal with asynchronous calls. The reason being is (in short) a JavaScript engine executes synchronous code first and then it executes asynchronous code.

Ideally you should wait until they accomplish and put your desired work inside their callback function. So over here you can either

call your code inside .then of Book.get() function
Or chain the promise and call desired code.

// 1. First way
var getBook = Book.get({id:$stateParams.id,min:0,max:3}).$promise.then(function(data){
  vm.list=data;
  // Put your code here
}).finally(function () {

});

// 2. Second way
getBook.then(function(){
   vm.top= vm.list && vm.list.name;
});

edited Apr 27, 2018 at 12:40

Peter Mortensen

31.4k22 gold badges110 silver badges134 bronze badges

answered Apr 27, 2018 at 8:12

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Run code after query in AngularJS

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related