Powershell while loop

Question

The below code keeps getting stuck in a loop when it gets to

$choice = read-host "Are you sure you want to disable the following user? (Y/N)" "$name"

I type in y and it keeps looping that question.

I've tried a do while & single IF statement. Any ideas on how to stop this loop?

$choice = ""
$User = read-host "enter username"
$Name = Get-ADuser -Identity $Username | Select-Object Name

while ($choice -notmatch "y/n"){
    $choice = read-host "Are you sure you want to disable the following user? (Y/N)" "$name"

    If ($Choice -eq"Y"){
        Disable-ADAccount $Username
    } 
}

postanote · Accepted Answer · 2018-04-30 04:17:14Z

7

You need to use the pipe for an or statement to work not a slash

This...

while ($choice -notmatch "y/n"

...should be this...

while ($choice -notmatch "y|n"

This is wrong, because you do not have a populated variable in the posted code to use...

Disable-ADAccount $Username

... based on your code, it should be this...

Disable-ADAccount $User

No need to seperate the variable in the choice statment. Just do this.

$choice = read-host "Are you sure you want to disable the following user? (Y or N) $name"

Example:

$choice = ""
$User = read-host "enter username"
$Name = $User

while ($choice -notmatch "y|n")
{
    $choice = read-host "Are you sure you want to disable the following user? (Y/N) $Name"

    If ($Choice -eq "y")
    { $User } 
}

enter username: test
Are you sure you want to disable the following user? (Y/N) test: u
Are you sure you want to disable the following user? (Y/N) test: u
Are you sure you want to disable the following user? (Y/N) test: y
test


enter username: test1
Are you sure you want to disable the following user? (Y/N) test1: h
Are you sure you want to disable the following user? (Y/N) test1: h
Are you sure you want to disable the following user? (Y/N) test1: n

answered Apr 30, 2018 at 4:17

postanote

16.4k3 gold badges17 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gvee Over a year ago

My two pennies: while ($choice -notin "y", "n") {... is simpler and easier to understand

Collectives™ on Stack Overflow

Powershell while loop

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related