JavaScript Functions And Events

Question

I'm making a function that takes two inputs and makes a select box from their contents but when I run the code it doesn't work and doesn't give me any errors.
When I run the function by itself and give it the inputs manually it seems to work just fine.

The code:

var start = parseInt(document.getElementById("start")),
  end = parseInt(document.getElementById("end")),
  button = document.getElementById("button");

button.onclick = function(x, y) {
  "use strict";
  var years;
  document.write("<select>");
  for (years = start; years <= end; years++) {
    document.write("<option value=\"" + years + "\">" + years + "</option>");
  };
  document.write("</select>");
};

<body>
  <input id="start" type="text" />
  <input id="end" type="text" />
  <button id="button">Make Select Box</button>
</body>

On a side note, please get used to new ways of appending elements to DOM. document.write is not a good way to do this. — 31piy
– 31piy, Commented May 8, 2018 at 10:25
You need to access the input values inside the event handler (i.e. every time when the button is clicked), not just once at the beginning — Bergi
– Bergi, Commented May 8, 2018 at 10:26

hsz · Accepted Answer · 2018-05-08 10:23:59Z

1

var start = parseInt(document.getElementById("start"))

This part is parsing whole HTML Element. You have to extract its value:

var start = parseInt(document.getElementById("start").value)

This also should happen inside the onclick callback. If you'll assign this value before clicking - it'll not change at all.

answered May 8, 2018 at 10:23

hsz

153k63 gold badges268 silver badges320 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

JavaScript Functions And Events

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related