From C# to Java

Question

Can someone help me convert this C# function to java function?

Could i make some simple for loop instead of all these foreach?

 static Queue RadixSort(Queue Items, int Digits)
    {

        int Digit = Digits - 1;
        while (Digit >= 0)
        {
            Queue Zero = new Queue();
            Queue One = new Queue();
            Queue Two = new Queue();
            Queue Three = new Queue();
            Queue Four = new Queue();
            Queue Five = new Queue();
            Queue Six = new Queue();
            Queue Seven = new Queue();
            Queue Eight = new Queue();
            Queue Nine = new Queue();
            int UpperLimit = Items.Count;
            int counter = 1;
            while (counter <= UpperLimit)
            {
                int i = Convert.ToInt32(Items.Dequeue());
                counter++;

                switch (i.ToString().PadLeft(Digits, '0')[Digit])
                {
                    case '0':
                        Zero.Enqueue(i);
                        continue;
                    case '1':
                        One.Enqueue(i);
                        continue;
                    case '2':
                        Two.Enqueue(i);
                        continue;
                    case '3':
                        Three.Enqueue(i);
                        continue;
                    case '4':
                        Four.Enqueue(i);
                        continue;
                    case '5':
                        Five.Enqueue(i);
                        continue;
                    case '6':
                        Six.Enqueue(i);
                        continue;
                    case '7':
                        Seven.Enqueue(i);
                        continue;
                    case '8':
                        Eight.Enqueue(i);
                        continue;
                    case '9':
                        Nine.Enqueue(i);
                        continue;
                }
            }
            Items = new Queue();
            foreach (int i in Zero)
            {
                Items.Enqueue(i);
            }
            foreach (int i in One)
            {
                Items.Enqueue(i);
            }
            foreach (int i in Two)
            {
                Items.Enqueue(i);
            }
            foreach (int i in Three)
            {
                Items.Enqueue(i);
            }
            foreach (int i in Four)
            {
                Items.Enqueue(i);
            }
            foreach (int i in Five)
            {
                Items.Enqueue(i);
            }
            foreach (int i in Six)
            {
                Items.Enqueue(i);
            }
            foreach (int i in Seven)
            {
                Items.Enqueue(i);
            }
            foreach (int i in Eight)
            {
                Items.Enqueue(i);
            }
            foreach (int i in Nine)
            {
                Items.Enqueue(i);
            }
            Digit--;
        }
        return Items;
    }

Is it just me or does this scream thedailywtf.com? Seriously though, I would not even consider porting this code. Without spending the time to really disassemble it, it looks like a totally bad design. Look into Java's collection classes and comparators. Using a bunch of queues like this to sort the contents of another queue .... crazy! — drekka
– drekka, Commented Feb 18, 2011 at 2:48
Indeed. "Wtf?" :-) Not only can you port it, but it can be done in 1/4th (or less) the lines. — user166390
– user166390, Commented Feb 18, 2011 at 3:08

Dylan Knowles · Accepted Answer · 2011-02-18 02:13:38Z

5

In Java, you can write

for (int i : <QueueName>)
{
}

(As for cleaning up and refactoring the rest of the code, I leave that up to you :D)

Good luck, and I hope that helps!

answered Feb 18, 2011 at 2:13

Dylan Knowles

2,8031 gold badge27 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

R. Martinho Fernandes Over a year ago

All the rest should be pretty similar.

hogni89 · Accepted Answer · 2011-02-18 02:38:42Z

1

for(int Digit = Digits-1; Digit >= 0; Digit--) {
    // Your code here
}

or

int Digit = Digits-1;
while(Digit >= 0) {
    // Your code here
    Digit--;
}

When compiled, they are the same :)

answered Feb 18, 2011 at 2:38

hogni89

1,7196 gold badges22 silver badges41 bronze badges

Collectives™ on Stack Overflow

From C# to Java

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related