Command not found in bash script

Question

I have a folder containing some files including ".bar" files. Now I would like to make a bash script that finds these ".bar" files and creates a folder with the same name. However I can't seem to get the syntax right.

I use:

#!/bin/bash
PATH="folder"

for filename in ${PATH}/*.bar; do
    mkdir $(basename ${filename%.*})
done

It seems to work when I use it in a terminal, but when I put in in a script it fails with the error: "basename: command not found" and "mkdir: command not found". How can I get this to work?

PATH is a very important reserved variable. Because you're replacing its value in the second line, you whole script breaks. — Robin479
– Robin479, Commented May 17, 2018 at 15:05
@Robin479. That fixes it indeed. Can you post it as an answer so I can accept it? — Frank
– Frank, Commented May 17, 2018 at 15:09

chepner · Accepted Answer · 2018-05-17 15:31:04Z

2

try this

#!/bin/bash
folderpath="folder"

for filename in "${folderpath}"/*.bar; do
    mkdir "$(basename "${filename%.*}")"
done

PATH is an internal shell variable and shouldn't be used in your shell script.

edited May 17, 2018 at 15:31

chepner

538k77 gold badges594 silver badges746 bronze badges

answered May 17, 2018 at 15:11

Eby Jacob

1,4681 gold badge13 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

chepner Over a year ago

All all-uppercase variables are reserved for use by the shell.

Collectives™ on Stack Overflow

Command not found in bash script

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related